Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 76483005: Emit Media Source stream type and codecs to chrome://media-internals. (Closed)

Created:
7 years, 1 month ago by scherkus (not reviewing)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@sort_keys
Visibility:
Public.

Description

Emit Media Source stream type and codecs to chrome://media-internals.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/chunk_demuxer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 3 chunks +3 lines, -1 line 0 comments Download
M media/filters/stream_parser_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/stream_parser_factory.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
WDYT? I'm not too hot on how we have to plumb both MediaLog and LogCB. ...
7 years, 1 month ago (2013-11-20 00:33:36 UTC) #1
acolwell GONE FROM CHROMIUM
7 years, 1 month ago (2013-11-20 01:29:06 UTC) #2
On 2013/11/20 00:33:36, scherkus wrote:
> WDYT? I'm not too hot on how we have to plumb both MediaLog and LogCB.
> 
> (also I'm not sure this works ... firing this off before I hop into a car)

Not really a fan of this. Why don't we just put code in Pipeline to report the
codecs? The codecs would imply the container type so you might not need it. 

I believe this would also only provide information for the last SourceBuffer
created unless you are allowed to have multiple instances of properties with the
same name.

Powered by Google App Engine
This is Rietveld 408576698