Enable streamlined-apps flag on Chrome for Mac.

Enable streamlined-apps flag on Chrome for Mac.

- Make --enable-streamlined-hosted-apps available on Mac.
- Removed #ifdefs so that "Add shortcut to this website" creates a
  hosted app for that website.
- Added blank imlpementation of ShowCreateWebAppShortcutsDialog for
  Mac, which will be implemented later.

BUG=437138
Committed: https://crrev.com/6d1594deb6fe3e201efdacacbc853d06cdb36cc5
Cr-Commit-Position: refs/heads/master@{#306319}

[mitchellj, 2014-11-27 04:46:24]

mitchelljones@chromium.org changed reviewers:
+ jackhou@chromium.org

[jackhou1, 2014-11-27 05:51:52]

https://codereview.chromium.org/764753003/diff/1/chrome/browser/extensions/ta...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/764753003/diff/1/chrome/browser/extensions/ta...
chrome/browser/extensions/tab_helper.cc:303: case CREATE_SHORTCUT: {
It looks like we never show the IDC_CREATE_SHORTCUTS option on Mac:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

So it should be fine to if-def out this case.

We'd also never hit this case because TabHelper::CanCreateApplicationShortcuts
always returns false on Mac.

This would also mean you don't need to add create_application_shortcut_cocoa.cc.

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_command_controller.cc:1111:
command_updater_.UpdateCommandEnabled(IDC_CREATE_HOSTED_APP,
If we're leaving IDC_CREATE_SHORCUTS if-defed out on Mac, I'd keep the comment
and if-def here, and just move IDC_CREATE_HOSTED_APP below the #endif.

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_di...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_di...
chrome/browser/ui/browser_dialogs.h:68: // Shows the create web app shortcut
dialog box.
This can stay if-defed out too.

[mitchellj, 2014-11-27 23:29:45]

https://codereview.chromium.org/764753003/diff/1/chrome/browser/extensions/ta...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/764753003/diff/1/chrome/browser/extensions/ta...
chrome/browser/extensions/tab_helper.cc:303: case CREATE_SHORTCUT: {
On 2014/11/27 05:51:52, jackhou1 wrote:
> It looks like we never show the IDC_CREATE_SHORTCUTS option on Mac:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> 
> So it should be fine to if-def out this case.
> 
> We'd also never hit this case because TabHelper::CanCreateApplicationShortcuts
> always returns false on Mac.
> 
> This would also mean you don't need to add
create_application_shortcut_cocoa.cc.

Done.

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_co...
File chrome/browser/ui/browser_command_controller.cc (right):

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_co...
chrome/browser/ui/browser_command_controller.cc:1111:
command_updater_.UpdateCommandEnabled(IDC_CREATE_HOSTED_APP,
On 2014/11/27 05:51:52, jackhou1 wrote:
> If we're leaving IDC_CREATE_SHORCUTS if-defed out on Mac, I'd keep the comment
> and if-def here, and just move IDC_CREATE_HOSTED_APP below the #endif.

Done.

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_di...
File chrome/browser/ui/browser_dialogs.h (right):

https://codereview.chromium.org/764753003/diff/1/chrome/browser/ui/browser_di...
chrome/browser/ui/browser_dialogs.h:68: // Shows the create web app shortcut
dialog box.
On 2014/11/27 05:51:52, jackhou1 wrote:
> This can stay if-defed out too.

Done.

[jackhou1, 2014-11-27 23:31:44]

lgtm

[mitchellj, 2014-11-27 23:47:46]

mitchelljones@chromium.org changed reviewers:
+ sky@chromium.org

[mitchellj, 2014-11-27 23:47:47]

Sky could you please review as owner? Thanks.

[sky, 2014-12-01 17:21:03]

https://codereview.chromium.org/764753003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/764753003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/tab_helper.cc:332: NOTREACHED();
Is it nos possible to end up here on a mac if pending_web_app_action_ is
CREATE_SHORTCUT?

[mitchellj, 2014-12-01 23:36:16]

On 2014/12/01 17:21:03, sky wrote:
>
https://codereview.chromium.org/764753003/diff/20001/chrome/browser/extension...
> File chrome/browser/extensions/tab_helper.cc (right):
> 
>
https://codereview.chromium.org/764753003/diff/20001/chrome/browser/extension...
> chrome/browser/extensions/tab_helper.cc:332: NOTREACHED();
> Is it nos possible to end up here on a mac if pending_web_app_action_ is
> CREATE_SHORTCUT?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
I don't believe this is the case. We only show the IDC_CREATE_SHORTCUTS option
in the wrench menu if show_create_shortcuts is true, which is set to be false on
OS_MACOSX.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ext...
CanCreateApplicationShortcuts also returns false on OS_MACOSX.

[sky, 2014-12-01 23:50:38]

Ok, LGTM

[mitchellj, 2014-12-01 23:55:56]

The CQ bit was checked by mitchelljones@chromium.org

[commit-bot: I haz the power, 2014-12-01 23:56:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/764753003/20001

[commit-bot: I haz the power, 2014-12-02 01:42:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-02 01:44:42]

Patchset 2 (id:??) landed as
https://crrev.com/6d1594deb6fe3e201efdacacbc853d06cdb36cc5
Cr-Commit-Position: refs/heads/master@{#306319}