base: Add three helper functions to Values API.

chrome/browser/prefs/pref_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_service.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 28 matching lines @@
 
 // A helper function for RegisterLocalized*Pref that creates a Value* based on
 // the string value in the locale dll.  Because we control the values in a
 // locale dll, this should always return a Value of the appropriate type.
 Value* CreateLocaleDefaultValue(base::Value::Type type, int message_id) {
   std::string resource_string = l10n_util::GetStringUTF8(message_id);
   DCHECK(!resource_string.empty());
   switch (type) {
     case Value::TYPE_BOOLEAN: {
       if ("true" == resource_string)
-        return Value::CreateBooleanValue(true);
+        return base::TrueValue();
       if ("false" == resource_string)
-        return Value::CreateBooleanValue(false);
+        return base::FalseValue();
       break;
     }
 
     case Value::TYPE_INTEGER: {
       int val;
       base::StringToInt(resource_string, &val);
       return Value::CreateIntegerValue(val);
     }
 
     case Value::TYPE_DOUBLE: {
       double val;
       base::StringToDouble(resource_string, &val);
       return Value::CreateDoubleValue(val);
     }
 
     case Value::TYPE_STRING: {
       return Value::CreateStringValue(resource_string);
     }
 
     default: {
       NOTREACHED() <<
           "list and dictionary types cannot have default locale values";
     }
   }
   NOTREACHED();
-  return Value::CreateNullValue();
+  return base::NullValue();
 }
 
 // Forwards a notification after a PostMessage so that we can wait for the
 // MessageLoop to run.
 void NotifyReadError(int message_id) {
   ShowProfileErrorDialog(message_id);
 }
 
 // Shows notifications which correspond to PersistentPrefStore's reading errors.
 class ReadErrorHandler : public PersistentPrefStore::ReadErrorDelegate {
@@ skipping 806 matching lines @@
   return pref_value_store()->PrefValueFromDefaultStore(name_.c_str());
 }
 
 bool PrefService::Preference::IsUserModifiable() const {
   return pref_value_store()->PrefValueUserModifiable(name_.c_str());
 }
 
 bool PrefService::Preference::IsExtensionModifiable() const {
   return pref_value_store()->PrefValueExtensionModifiable(name_.c_str());
 }