Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 764643002: Remove WebViewKey in rules registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api.cc
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index 509dd98609964fbf99c9fabff4b76475e2253067..8f4c89bfe85aed50e140f6d553bbd9b5fdb4ac24 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -23,6 +23,7 @@
#include "content/public/browser/resource_request_info.h"
#include "content/public/browser/user_metrics.h"
#include "extensions/browser/api/activity_log/web_request_constants.h"
+#include "extensions/browser/api/declarative/rules_registry_service.h"
#include "extensions/browser/api/declarative_webrequest/request_stage.h"
#include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"
#include "extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h"
@@ -661,9 +662,9 @@ ExtensionWebRequestEventRouter::~ExtensionWebRequestEventRouter() {
void ExtensionWebRequestEventRouter::RegisterRulesRegistry(
void* browser_context,
- const extensions::RulesRegistry::WebViewKey& webview_key,
+ int rules_registry_id,
scoped_refptr<extensions::WebRequestRulesRegistry> rules_registry) {
- RulesRegistryKey key(browser_context, webview_key);
+ RulesRegistryKey key(browser_context, rules_registry_id);
if (rules_registry.get())
rules_registries_[key] = rules_registry;
else
@@ -1966,11 +1967,11 @@ bool ExtensionWebRequestEventRouter::ProcessDeclarativeRules(
const net::HttpResponseHeaders* original_response_headers) {
extensions::WebViewRendererState::WebViewInfo web_view_info;
bool is_web_view_guest = GetWebViewInfo(request, &web_view_info);
+ int rules_registry_id = is_web_view_guest
+ ? web_view_info.rules_registry_id
+ : RulesRegistryService::kDefaultRulesRegistryID;
- extensions::RulesRegistry::WebViewKey webview_key(
- is_web_view_guest ? web_view_info.embedder_process_id : 0,
- is_web_view_guest ? web_view_info.instance_id : 0);
- RulesRegistryKey rules_key(browser_context, webview_key);
+ RulesRegistryKey rules_key(browser_context, rules_registry_id);
// If this check fails, check that the active stages are up-to-date in
// extensions/browser/api/declarative_webrequest/request_stage.h .
DCHECK(request_stage & extensions::kActiveStages);
@@ -1992,8 +1993,8 @@ bool ExtensionWebRequestEventRouter::ProcessDeclarativeRules(
}
void* cross_browser_context = GetCrossBrowserContext(browser_context);
- RulesRegistryKey cross_browser_context_rules_key(
- cross_browser_context, webview_key);
+ RulesRegistryKey cross_browser_context_rules_key(cross_browser_context,
+ rules_registry_id);
if (cross_browser_context &&
rules_registries_.find(cross_browser_context_rules_key) !=
rules_registries_.end()) {
« no previous file with comments | « extensions/browser/api/web_request/web_request_api.h ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698