chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc - Issue 764643002: Remove WebViewKey in rules registry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 764643002: Remove WebViewKey in rules registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/chrome_content_rules_registry.cc ('k') | chrome/test/data/extensions/platform_apps/web_view/rules_registry/main.html » ('j') | extensions/browser/api/declarative/declarative_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

index b49807d9aa75d81fb15ddcfb2ea85fc2c0941cc7..4474755441da7ff517553a62bf1ce0a2a15455ce 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

@@ -18,6 +18,7 @@

#include "chrome/common/extensions/extension_test_util.h"

#include "components/url_matcher/url_matcher_constants.h"

#include "content/public/test/test_browser_thread.h"

+#include "extensions/browser/api/declarative/rules_registry_service.h"

#include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"

#include "extensions/browser/api/web_request/web_request_api_helpers.h"

#include "net/base/request_priority.h"

@@ -50,11 +51,10 @@ namespace keys2 = url_matcher::url_matcher_constants;

class TestWebRequestRulesRegistry : public WebRequestRulesRegistry {

public:

- TestWebRequestRulesRegistry(

- scoped_refptr<InfoMap> extension_info_map)

+ TestWebRequestRulesRegistry(scoped_refptr<InfoMap> extension_info_map)

: WebRequestRulesRegistry(NULL /*profile*/,

NULL /* cache_delegate */,

- WebViewKey(0, 0)),

+ RulesRegistryService::kDefaultRulesRegistryID),

num_clear_cache_calls_(0) {

SetExtensionInfoMapForTesting(extension_info_map);

}