chrome/browser/extensions/api/declarative/declarative_apitest.cc - Issue 764643002: Remove WebViewKey in rules registry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/declarative_apitest.cc

Issue 764643002: Remove WebViewKey in rules registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add browser tests. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/declarative/declarative_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative/declarative_apitest.cc b/chrome/browser/extensions/api/declarative/declarative_apitest.cc

index 4de8d34abf4173f24bf9dbca0bac5a701e33612d..a6f51a7b2c8bd6b2d7570eb28286a414cb95624b 100644

--- a/chrome/browser/extensions/api/declarative/declarative_apitest.cc

+++ b/chrome/browser/extensions/api/declarative/declarative_apitest.cc

@@ -114,7 +114,7 @@ class DeclarativeApiTest : public ExtensionApiTest {

extensions::RulesRegistryService::Get(browser()->profile());

scoped_refptr<RulesRegistry> rules_registry =

rules_registry_service->GetRulesRegistry(

- RulesRegistry::WebViewKey(0, 0),

+ RulesRegistryService::kDefaultRulesRegistryID,

extensions::declarative_webrequest_constants::kOnRequest);

std::vector<linked_ptr<RulesRegistry::Rule> > rules;

BrowserThread::PostTask(