Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 764643002: Remove WebViewKey in rules registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Renaming move "remove rules registry for webview" part to WebViewGuest. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.h
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h
index 31ca93e13aed2a8b086f149c177a7b92b23dd002..e32ac63d01cc43c9ce2d1ef9fa63475328de626a 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.h
+++ b/extensions/browser/guest_view/web_view/web_view_guest.h
@@ -57,6 +57,13 @@ class WebViewGuest : public GuestView<WebViewGuest>,
static const char Type[];
+ // Return the stored rules registry ID of the given webview. Will generate
+ // an ID for the first query.
+ static int GetOrGenerateRulesRegistryID(
+ int embedder_process_id,
+ int webview_instance_id,
Fady Samuel 2014/11/28 11:34:25 nit: web_view_instance_id to be more consistent wi
Xi Han 2014/11/28 16:12:57 Done.
+ content::BrowserContext* browser_context);
+
// Request navigating the guest to the provided |src| URL.
void NavigateGuest(const std::string& src, bool force_navigation);
@@ -236,6 +243,7 @@ class WebViewGuest : public GuestView<WebViewGuest>,
private:
friend class WebViewPermissionHelper;
+
WebViewGuest(content::BrowserContext* browser_context,
int guest_instance_id);
@@ -315,6 +323,9 @@ class WebViewGuest : public GuestView<WebViewGuest>,
void SetUpAutoSize();
+ // Store the ID of this webview in the RulesRegistryService.
Fady Samuel 2014/11/28 11:34:25 nit: // Identifies the set of rules registries be
Xi Han 2014/11/28 16:12:57 Done.
+ int rules_registry_id_;
+
// Handles find requests and replies for the webview find API.
WebViewFindHelper find_helper_;

Powered by Google App Engine
This is Rietveld 408576698