extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h - Issue 764643002: Remove WebViewKey in rules registry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

Issue 764643002: Remove WebViewKey in rules registry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/declarative_content/content_rules_registry.h ('K') | « extensions/browser/api/declarative_content/content_rules_registry.h ('k') | extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc » ('j') | extensions/browser/api/web_request/web_request_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

index 5b14e21bf1d43dbccc048fbc3d66fcaa84b2eb61..66e0e0bebb30c1becdad1eca8ec742f108f2a377 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

+++ b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

@@ -80,7 +80,7 @@ class WebRequestRulesRegistry : public RulesRegistry {

// storage functionality suspended.

WebRequestRulesRegistry(content::BrowserContext* browser_context,

RulesCacheDelegate* cache_delegate,

- const WebViewKey& webview_key);

+ int rule_registry_id);

Fady Samuel 2014/11/26 23:39:41 rules_registry_id

Xi Han 2014/11/27 23:25:25 Done.

// TODO(battre): This will become an implementation detail, because we need

// a way to also execute the actions of the rules.