Remove WebViewKey in rules registry.

extensions/browser/api/declarative/declarative_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/declarative/declarative_api.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/task_runner_util.h"
@@ skipping 130 matching lines @@
 
   int webview_instance_id = 0;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(1, &webview_instance_id));
   int embedder_process_id = render_view_host()->GetProcess()->GetID();
 
   bool has_webview = webview_instance_id != 0;
   if (has_webview != IsWebViewEvent(event_name))
     EXTENSION_FUNCTION_ERROR(kWebViewExpectedError);
   event_name = GetWebRequestEventName(event_name);
 
-  // If we are not operating on a particular <webview>, then the key is (0, 0).
-  RulesRegistry::WebViewKey key(
-      webview_instance_id ? embedder_process_id : 0, webview_instance_id);
+  // If we are not operating on a particular <webview>, then the key is 0.
+  int rules_registry_id = RulesRegistryService::kDefaultRulesRegistryID;
+  if (has_webview) {
+    rules_registry_id = WebViewGuest::GetOrGenerateRulesRegistryID(
+        embedder_process_id, webview_instance_id, browser_context());

[Fady Samuel, 2014/11/28 11:35:51]

make it web_view_instance_id to be consistent with the new naming.

[Xi Han, 2014/11/28 16:12:56]

Done.

+  }
 
   // The following call will return a NULL pointer for apps_shell, but should
   // never be called there anyways.
-  rules_registry_ = RulesRegistryService::Get(browser_context())->
-      GetRulesRegistry(key, event_name);
+  rules_registry_ =
+      RulesRegistryService::Get(browser_context())
+          ->GetRulesRegistry(rules_registry_id, has_webview, event_name);

[Fady Samuel, 2014/11/28 11:35:51]

I don't think we need to pass in has_webview anymore.

[Xi Han, 2014/11/28 16:12:56]

Removed.

   DCHECK(rules_registry_.get());
   // Raw access to this function is not available to extensions, therefore
   // there should never be a request for a nonexisting rules registry.
   EXTENSION_FUNCTION_VALIDATE(rules_registry_.get());
 
   if (content::BrowserThread::CurrentlyOn(rules_registry_->owner_thread())) {
     bool success = RunAsyncOnCorrectThread();
     SendResponse(success);
   } else {
     scoped_refptr<base::MessageLoopProxy> message_loop_proxy =
@@ skipping 47 matching lines @@
   } else {
     rules_registry_->GetAllRules(extension_id(), &rules);
   }
 
   results_ = GetRules::Results::Create(rules);
 
   return true;
 }
 
 }  // namespace extensions