Remove WebViewKey in rules registry.

extensions/browser/api/declarative/rules_registry_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_DECLARATIVE_RULES_REGISTRY_SERVICE_H__
 #define EXTENSIONS_BROWSER_API_DECLARATIVE_RULES_REGISTRY_SERVICE_H__
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 20 matching lines @@
 }
 
 namespace extensions {
 
 // This class owns all RulesRegistries implementations of an ExtensionService.
 // This class lives on the UI thread.
 class RulesRegistryService : public BrowserContextKeyedAPI,
                              public content::NotificationObserver,
                              public ExtensionRegistryObserver {
  public:
-  typedef RulesRegistry::WebViewKey WebViewKey;
+  static const int kDefultRulesRegistryID = 0;

[Fady Samuel, 2014/11/26 23:39:41]

typo: kDefaultRulesRegistryID

[Xi Han, 2014/11/27 23:25:25]

Renamed.

+
   struct RulesRegistryKey {
     std::string event_name;
-    WebViewKey webview_key;
-    RulesRegistryKey(const std::string event_name,
-                     const WebViewKey& webview_key)
-        : event_name(event_name),
-          webview_key(webview_key) {}
+    int rules_registry_id;
+    RulesRegistryKey(const std::string event_name, int rules_registry_id)
+        : event_name(event_name), rules_registry_id(rules_registry_id) {}

[Fady Samuel, 2014/11/26 23:39:41]

Put this on the next line.

[Xi Han, 2014/11/27 23:25:25]

Done.

     bool operator<(const RulesRegistryKey& other) const {
       return (event_name < other.event_name) ||
-          ((event_name == other.event_name) &&
-          (webview_key < other.webview_key));
+             ((event_name == other.event_name) &&
+              (rules_registry_id < other.rules_registry_id));
     }
   };
 
   explicit RulesRegistryService(content::BrowserContext* context);
   ~RulesRegistryService() override;
 
   // Unregisters refptrs to concrete RulesRegistries at other objects that were
   // created by us so that the RulesRegistries can be released.
   void Shutdown() override;
 
   // BrowserContextKeyedAPI implementation.
   static BrowserContextKeyedAPIFactory<RulesRegistryService>*
       GetFactoryInstance();
 
   // Convenience method to get the RulesRegistryService for a context.
   static RulesRegistryService* Get(content::BrowserContext* context);
 
+  int GetNextRulesRegistryId();

[Fady Samuel, 2014/11/26 23:39:41]

GetNextRulesRegistryID

[Xi Han, 2014/11/27 23:25:25]

Done.

+
   // Registers the default RulesRegistries used in Chromium.
-  void EnsureDefaultRulesRegistriesRegistered(const WebViewKey& webview_key);
+  void EnsureDefaultRulesRegistriesRegistered(int rules_registry_id,
+                                              bool is_web_view);

[Fady Samuel, 2014/11/26 23:39:41]

Avoid this is_web_view. Maybe instead:

GetNextRulesRegistryID(bool cache_rules);

Then store a map here from rulesregistry ID to bool.

[Xi Han, 2014/11/27 23:25:25]

Yes, this name is more clear.

 
   // Registers a RulesRegistry and wraps it in an InitializingRulesRegistry.
   void RegisterRulesRegistry(scoped_refptr<RulesRegistry> rule_registry);
 
-  // Returns the RulesRegistry for |event_name| and |webview_key| or NULL if no
-  // such registry has been registered. Default rules registries (such as the
-  // WebRequest rules registry) will be created on first access.
-  scoped_refptr<RulesRegistry> GetRulesRegistry(const WebViewKey& webview_key,
+  // Returns the RulesRegistry for |event_name| and |rules_registry_id| or
+  // NULL if no such registry has been registered. Default rules registries
+  // (such as the WebRequest rules registry) will be created on first access.
+  scoped_refptr<RulesRegistry> GetRulesRegistry(int rules_registry_id,
+                                                bool is_web_view,
                                                 const std::string& event_name);
 
   // Accessors for each type of rules registry.
   ContentRulesRegistry* content_rules_registry() const {
     CHECK(content_rules_registry_);
     return content_rules_registry_;
   }
 
   // Removes all rules registries of a given webview embedder process ID.
   void RemoveWebViewRulesRegistries(int process_id);
@@ skipping 32 matching lines @@
       void (RulesRegistry::*notification_callback)(const std::string&),
       const std::string& extension_id);
 
   // BrowserContextKeyedAPI implementation.
   static const char* service_name() {
     return "RulesRegistryService";
   }
   static const bool kServiceHasOwnInstanceInIncognito = true;
   static const bool kServiceIsNULLWhileTesting = true;
 
+  int current_rules_registry_id_;
+
   RulesRegistryMap rule_registries_;
 
   // We own the parts of the registries which need to run on the UI thread.
   ScopedVector<RulesCacheDelegate> cache_delegates_;
 
   // Weak pointer into rule_registries_ to make it easier to handle content rule
   // conditions.
   ContentRulesRegistry* content_rules_registry_;
 
   content::NotificationRegistrar registrar_;
 
   // Listen to extension load, unloaded notification.
   ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
       extension_registry_observer_;
 
   content::BrowserContext* browser_context_;
 
   DISALLOW_COPY_AND_ASSIGN(RulesRegistryService);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_DECLARATIVE_RULES_REGISTRY_SERVICE_H__