Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 764463002: rename SkDrawable to SkADrawable (Closed)

Created:
6 years ago by reed2
Modified:
6 years ago
Reviewers:
tfarina, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

rename SkDrawable to SkADrawable BUG=skia: Committed: https://skia.googlesource.com/skia/+/986ca61cf7be3ec590f8820e9b7ba042ac2948fe

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -180 lines) Patch
M gyp/animator.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + src/animator/SkADrawable.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + src/animator/SkADrawable.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/animator/SkAnimateActive.h View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimateActive.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkAnimateBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkAnimateBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimateField.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/animator/SkAnimateMaker.h View 1 chunk +1 line, -1 line 1 comment Download
M src/animator/SkBoundable.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/animator/SkDisplayAdd.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/animator/SkDisplayAdd.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/animator/SkDisplayApply.h View 4 chunks +7 lines, -7 lines 0 comments Download
M src/animator/SkDisplayApply.cpp View 10 chunks +11 lines, -11 lines 0 comments Download
M src/animator/SkDisplayEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkDisplayEvents.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkDisplayList.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/animator/SkDisplayList.cpp View 8 chunks +10 lines, -10 lines 0 comments Download
M src/animator/SkDisplayMovie.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/animator/SkDraw3D.h View 2 chunks +2 lines, -2 lines 1 comment Download
M src/animator/SkDrawClip.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkDrawExtraPathEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkDrawGroup.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/animator/SkDrawGroup.cpp View 16 chunks +31 lines, -31 lines 0 comments Download
M src/animator/SkDrawMatrix.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/animator/SkDrawPaint.h View 3 chunks +3 lines, -3 lines 0 comments Download
D src/animator/SkDrawable.h View 1 chunk +0 lines, -28 lines 0 comments Download
D src/animator/SkDrawable.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
M src/animator/SkHitTest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkIntArray.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/animator/SkOperand.h View 3 chunks +3 lines, -3 lines 1 comment Download
M src/animator/SkSnapshot.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/animator/SkTextToPath.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
reed2
6 years ago (2014-11-26 03:25:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764463002/1
6 years ago (2014-11-26 03:25:41 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-11-26 03:25:42 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years ago (2014-11-26 09:25:52 UTC) #7
tfarina
lgtm I randomly looked at some files. You can run: for f in $(git diff ...
6 years ago (2014-11-26 14:26:30 UTC) #9
mtklein
lgtm (I do not care if the headers are sorted.)
6 years ago (2014-11-26 14:39:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764463002/1
6 years ago (2014-11-26 14:48:19 UTC) #12
commit-bot: I haz the power
6 years ago (2014-11-26 16:50:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/986ca61cf7be3ec590f8820e9b7ba042ac2948fe

Powered by Google App Engine
This is Rietveld 408576698