Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 764433003: Flail a little against LLVM crash. (Closed)

Created:
6 years ago by mtklein_C
Modified:
6 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Flail a little against LLVM crash. Cannot reproduce this in my local Chromium checkout (using their Clang, just like the bots). BUG=skia: TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/701dd4fbd7942f98e413807491f62898941c142c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/core/SkColorTable.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkColorTable.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein
lgtm
6 years ago (2014-12-02 19:02:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764433003/1
6 years ago (2014-12-02 19:02:46 UTC) #4
commit-bot: I haz the power
Presubmit check for 764433003-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years ago (2014-12-02 19:02:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764433003/1
6 years ago (2014-12-02 21:06:21 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-02 21:17:09 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/701dd4fbd7942f98e413807491f62898941c142c

Powered by Google App Engine
This is Rietveld 408576698