net/cert/cert_status_flags.h - Issue 76443006: Certificate Transparency: Threading the CT verifier into the SSL client socket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_status_flags.h

Issue 76443006: Certificate Transparency: Threading the CT verifier into the SSL client socket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Previous patchset leaked information from another issue Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_status_flags.h

diff --git a/net/cert/cert_status_flags.h b/net/cert/cert_status_flags.h

index 630df650fe3f759e1230a30de495f3c977e20804..174745f3c5181660fce430e99c5d7464d1bde1b6 100644

--- a/net/cert/cert_status_flags.h

+++ b/net/cert/cert_status_flags.h

@@ -39,6 +39,12 @@ static const CertStatus CERT_STATUS_PINNED_KEY_MISSING = 1 << 13;

static const CertStatus CERT_STATUS_IS_EV = 1 << 16;

static const CertStatus CERT_STATUS_REV_CHECKING_ENABLED = 1 << 17;

// bit 18 was CERT_STATUS_IS_DNSSEC.

+// Bits 19 to 21 are for Certificate Transparency. Note that while

+// the current state can be represented with only 2 bits, the mapping

+// from bit to state will not be straightforward.

Ryan Sleevi 2013/11/25 06:49:31 Why not? Can we not just encapsulate it in a helpe

Eran M. (Google) 2013/11/25 17:18:33 Done, but the const names aren't pretty - PTAL.

+static const CertStatus CERT_STATUS_HAS_ANY_SCT = 1 << 19;

+static const CertStatus CERT_STATUS_HAS_SCT_FROM_KNOWN_LOG = 1 << 20;

+static const CertStatus CERT_STATUS_HAS_VALID_SCT = 1 << 21;

// Returns true if the specified cert status has an error set.

static inline bool IsCertStatusError(CertStatus status) {

« chrome/browser/io_thread.cc ('K') | « chrome/common/chrome_switches.cc ('k') | net/cert/ct_known_logs_keys.h » ('j') | net/cert/ct_known_logs_keys.h » ('J')