net/cert/ct_known_logs_keys.h - Issue 76443006: Certificate Transparency: Threading the CT verifier into the SSL client socket.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/cert/ct_known_logs_keys.h

Issue 76443006: Certificate Transparency: Threading the CT verifier into the SSL client socket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing compilation on non-NSS platforms Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef NET_CERT_CT_KNOWN_LOGS_KEYS_H_

	6 #define NET_CERT_CT_KNOWN_LOGS_KEYS_H_
	wtc 2013/11/26 01:47:23 Nit: perhaps these files should be named ct_known_ Nit: perhaps these files should be named ct_known_logs.h or ct_known_logs_data.h because they also contain the log descriptions. Eran M. (Google) 2013/11/26 14:45:53 Done. Show quoted text On 2013/11/26 01:47:23, wtc wrote: > > Nit: perhaps these files should be named ct_known_logs.h or ct_known_logs_data.h > because they also contain the log descriptions. Done.
	7

	8 namespace net {

	9

	10 extern const char kGooglePilotLogKey[];
	wtc 2013/11/26 01:47:23 Should these constants be inside namespace ct? Should these constants be inside namespace ct? Eran M. (Google) 2013/11/26 14:45:53 Done. Show quoted text On 2013/11/26 01:47:23, wtc wrote: > > Should these constants be inside namespace ct? Done.
	11 extern const size_t kGooglePilotLogKeyLength;

	12 extern const char kGooglePilotLogName[];

	13

	14 extern const char kGoogleTestLogKey[];

	15 extern const size_t kGoogleTestLogKeyLength;

	16 extern const char kGoogleTestLogName[];

	17

	18 } // namespace net

	19

	20 #endif // NET_CERT_CT_KNOWN_LOGS_KEYS_H_

OLD	NEW

« net/cert/cert_status_flags.h ('K') | « net/cert/cert_status_flags.cc ('k') | net/cert/ct_known_logs_keys.cc » ('j') | net/cert/ct_known_logs_keys.cc » ('J')