Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 76443003: Comment out the CHECK for trace_id for now (Closed)

Created:
7 years, 1 month ago by Yufeng Shen (Slow to review)
Modified:
7 years, 1 month ago
Reviewers:
jbauman
CC:
chromium-reviews, tdresser, sadrul
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Comment out the CHECK for trace_id for now The CHECK of trace_id for LatencyInfo is crashing chrome due to crbug.com/321116. Comment it out for now until we resolve the issue. BUG=321116 TEST=Chrome does not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236957

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/events/latency_info.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Yufeng Shen (Slow to review)
7 years, 1 month ago (2013-11-19 20:34:05 UTC) #1
Yufeng Shen (Slow to review)
On 2013/11/19 20:34:05, Yufeng Shen wrote: Ping. Sadrul, mind taking a quick look at this ...
7 years, 1 month ago (2013-11-22 20:21:18 UTC) #2
sadrul
latency info -> jbauman
7 years, 1 month ago (2013-11-22 20:41:03 UTC) #3
jbauman
lgtm
7 years, 1 month ago (2013-11-23 00:24:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/76443003/1
7 years, 1 month ago (2013-11-23 04:14:41 UTC) #5
Yufeng Shen (Slow to review)
On 2013/11/23 00:24:13, jbauman wrote: > lgtm Thanks John.
7 years, 1 month ago (2013-11-23 04:14:43 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) check_deps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=177887
7 years, 1 month ago (2013-11-23 05:18:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/76443003/1
7 years, 1 month ago (2013-11-23 07:20:39 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 20:26:30 UTC) #9
Message was sent while issue was closed.
Change committed as 236957

Powered by Google App Engine
This is Rietveld 408576698