Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 764423002: clang-format/java: No spaces around braces in initializer lists. (Closed)

Created:
6 years ago by Nico
Modified:
6 years ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang-format/java: No spaces around braces in initializer lists. Those spaces are explicitly optional for Google's Java style (Point 8 of https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.6.2-horizontal-whitespace) and not having spaces outnumbers spaces about 10-to-1 in our existing code. This also removes the space in annotations like `@Feature({"Android-AppBase"})` which is too looks like a good change. With this, all chromium-related java bits are upstreamed into clang-format and the java-specific section from .clang-format is gone again. BUG=429372 NOTRY=true Committed: https://crrev.com/1cc47034de564d0fd33a89c7d785a539b6c3a5a0 Cr-Commit-Position: refs/heads/master@{#306245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M .clang-format View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nico
6 years ago (2014-12-01 20:28:47 UTC) #2
newt (away)
lgtm thanks!
6 years ago (2014-12-01 20:41:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764423002/1
6 years ago (2014-12-01 20:46:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 20:46:48 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-01 20:47:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1cc47034de564d0fd33a89c7d785a539b6c3a5a0
Cr-Commit-Position: refs/heads/master@{#306245}

Powered by Google App Engine
This is Rietveld 408576698