desktop_window_tree_host_x11.cc: do not return immediately from DesktopWindowTreeHostX11::OnWMState…

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

Index: ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
index 3c992813568aa97c66c5617ef3a75b1be63f99dd..421891cb1983b15b9bd94954374fe6da0df3b2ef 100644
--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
@@ -1225,8 +1225,9 @@ gfx::Size DesktopWindowTreeHostX11::AdjustSize(
 
 void DesktopWindowTreeHostX11::OnWMStateUpdated() {
   std::vector< ::Atom> atom_list;
-  if (!ui::GetAtomArrayProperty(xwindow_, "_NET_WM_STATE", &atom_list))
-    return;
+  // It's acceptable that the call below fails, since some wms (e.g. Fluxbox)
+  // remove the _NET_WM_STATE property when no _NET_WM_STATE_* atom is set.

[pkotwicz, 2014/12/02 17:12:02]

How about: "Ignore the return value of ui::GetAtomArrayProperty(). Fluxbox
removes the _NET_WM_STATE property when no _NET_WM_STATE atoms are set."

Aside: I am unsure whether ui::GetAtomArrayProperty() should succeed when the
requested atom is not set. There are not enough uses of
ui::GetAtomArrayProperty() to make a strong case one way or the other.

[Lukasz Jagielski, 2014/12/02 22:29:33]

Yeah, my English needs some polishing (hope not to Polish it instead). That
comment has to wait until tomorrow though.

+  ui::GetAtomArrayProperty(xwindow_, "_NET_WM_STATE", &atom_list);
 
   bool was_minimized = IsMinimized();