Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 764373002: desktop_window_tree_host_x11.cc: do not return immediately from DesktopWindowTreeHostX11::OnWMState… (Closed)

Created:
6 years ago by Lukasz Jagielski
Modified:
6 years ago
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Linux: fix saving window state in fluxbox. DesktopWindowTreeHostX11::OnWMStateUpdated(): assume that none of the _NET_WM_STATE atoms are set if the _NET_WM_STATE window property is missing. Fluxbox removes the _NET_WM_STATE window property if none of the _NET_WM_STATE atoms are set. BUG=437816, 411705 Committed: https://crrev.com/6783cdb2f65a63ca7e83d9e53527fa2d64ce4dd3 Cr-Commit-Position: refs/heads/master@{#306595}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added comment #

Total comments: 2

Patch Set 3 : Comment fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
Lukasz Jagielski
Hi, PTAL at my CL proposition. Regards, Łukasz
6 years ago (2014-12-01 15:42:55 UTC) #2
Elliot Glaysher
The patch is good, but the description needs work. Something like: Linux: Fix saving window ...
6 years ago (2014-12-01 18:40:50 UTC) #3
pkotwicz
https://codereview.chromium.org/764373002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/764373002/diff/1/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1227 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1227: std::vector< ::Atom> atom_list; Can you please also add a ...
6 years ago (2014-12-01 19:11:25 UTC) #4
pkotwicz
Added crbug.com/411705 to this change list because this change list fixes that bug too
6 years ago (2014-12-02 02:22:08 UTC) #5
Lukasz Jagielski
6 years ago (2014-12-02 16:45:38 UTC) #6
pkotwicz
LGTM with comments. I slightly edited your change list description to make it clearer Sorry ...
6 years ago (2014-12-02 17:12:02 UTC) #7
Elliot Glaysher
lgtm if Peter is happy with it.
6 years ago (2014-12-02 18:12:29 UTC) #8
Lukasz Jagielski
https://codereview.chromium.org/764373002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/764373002/diff/20001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1229 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1229: // remove the _NET_WM_STATE property when no _NET_WM_STATE_* atom ...
6 years ago (2014-12-02 22:29:33 UTC) #9
Lukasz Jagielski
6 years ago (2014-12-03 12:50:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764373002/40001
6 years ago (2014-12-03 12:51:01 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-03 13:34:33 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-03 13:35:27 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6783cdb2f65a63ca7e83d9e53527fa2d64ce4dd3
Cr-Commit-Position: refs/heads/master@{#306595}

Powered by Google App Engine
This is Rietveld 408576698