Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 764353002: Follow up to CL 764533002. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch, zarah
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r42279 and CL 760383003. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -40 lines) Patch
M dart/pkg/compiler/lib/src/js_backend/namer.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download
M dart/pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 1 5 chunks +34 lines, -18 lines 0 comments Download
M dart/pkg/dart2js_incremental/lib/library_updater.dart View 1 10 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ahe
6 years ago (2014-12-01 14:59:43 UTC) #2
Johnni Winther
lgtm
6 years ago (2014-12-09 12:19:22 UTC) #3
ahe
PTAL
6 years ago (2014-12-11 10:19:36 UTC) #4
ahe
6 years ago (2014-12-11 10:20:01 UTC) #5
Johnni Winther
lgtm
6 years ago (2014-12-11 13:09:09 UTC) #6
ahe
6 years ago (2014-12-11 13:24:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698