Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 764283003: Fix the missing remove-link UI in protocol handler settings (Closed)

Created:
6 years ago by kaliamoorthi
Modified:
6 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, bartfab (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the missing remove-link UI in protocol handler settings A previous CL (https://codereview.chromium.org/518673003/) that introduced policy indicators for protocol handlers introduced a bug that results in remove-link option not being shown on protocol handler settings. The problem is caused by a variable name being replaced in the last minute. All occurrences of the variables were not replaced, resulting in the problem. This CL replaces all occurrences of the variable. BUG=433562 Committed: https://crrev.com/5d7960c88003f0e258b2ac5f5fd567ab8c642988 Cr-Commit-Position: refs/heads/master@{#306208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options/handler_options_list.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
kaliamoorthi
PTAL
6 years ago (2014-12-01 09:49:59 UTC) #2
bartfab (slow)
lgtm
6 years ago (2014-12-01 11:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764283003/1
6 years ago (2014-12-01 13:13:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/27345)
6 years ago (2014-12-01 13:16:51 UTC) #7
kaliamoorthi
PTAL
6 years ago (2014-12-01 14:07:37 UTC) #9
stevenjb
lgtm
6 years ago (2014-12-01 17:53:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764283003/1
6 years ago (2014-12-01 18:06:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-01 18:08:39 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-01 18:10:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d7960c88003f0e258b2ac5f5fd567ab8c642988
Cr-Commit-Position: refs/heads/master@{#306208}

Powered by Google App Engine
This is Rietveld 408576698