Issue 764233002: Ensure layout on replaced elements in anonymous wrappers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 764233002: Ensure layout on replaced elements in anonymous wrappers (Closed)

Created:
6 years ago by rhogan

Modified:
6 years ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Ensure layout on replaced elements in anonymous wrappers When dimensions change on an ancestor we need to layout all the way down through the percentage descendants. This means punching through any anonymous blocks that sit between them. If a child is anonymous and its parent has a percentage height then we need to layout that anonymous child so we can check for any percentage children it is managing for the DOM parent. BUG=414532 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186260

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
A	LayoutTests/fast/replaced/replaced-element-with-percentage-height-anonymous-block-parent.html	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/replaced/replaced-element-with-percentage-height-anonymous-block-parent-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764233002/40001

6 years ago (2014-12-01 21:25:25 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-01 22:01:07 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186260

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 764233002: Ensure layout on replaced elements in anonymous wrappers (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Messages