Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 76413004: Turn ASSERTs to CHECKs in test-heap.cc (Closed)

Created:
7 years, 1 month ago by danno
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Turn ASSERTs to CHECKs in test-heap.cc This fixes unused variable compile failures in release builds introduced in r17887. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M test/cctest/test-heap.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
7 years, 1 month ago (2013-11-19 17:27:47 UTC) #1
Jakob Kummerow
lgtm
7 years, 1 month ago (2013-11-19 17:29:29 UTC) #2
danno
7 years, 1 month ago (2013-11-19 17:29:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17888.

Powered by Google App Engine
This is Rietveld 408576698