Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 764113004: Remove exceptions for third_party/libc++/trunk/include/support/solaris and (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
6 years ago
Reviewers:
phajdan, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove exceptions for third_party/libc++/trunk/include/support/solaris and third_party/libc++/trunk/src/support/solaris/xlocale.c from the license checker. BUG=329819 R=phajdan@chromium.org NOTRY=true Committed: https://crrev.com/fa1f70ba4398e0b3f0a2e4976f872a83d83eafc6 Cr-Commit-Position: refs/heads/master@{#308092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Alexander Potapenko
PTAL
6 years ago (2014-12-01 15:28:25 UTC) #1
Alexander Potapenko
ping? On Mon, Dec 1, 2014 at 6:28 PM, <glider@chromium.org> wrote: > Reviewers: phajdan_chromium.org, > ...
6 years ago (2014-12-05 16:17:07 UTC) #2
Paweł Hajdan Jr.
LGTM, thanks! (watch out for my proper email address)
6 years ago (2014-12-12 15:59:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764113004/1
6 years ago (2014-12-12 16:02:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 16:03:30 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-12 16:04:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa1f70ba4398e0b3f0a2e4976f872a83d83eafc6
Cr-Commit-Position: refs/heads/master@{#308092}

Powered by Google App Engine
This is Rietveld 408576698