Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 764083002: Deprecate getMatchedCSSRules() (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
rune
CC:
arv+blink, blink-reviews, Inactive
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : one more #

Patch Set 4 : update platform expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M LayoutTests/fast/backgrounds/repeat/margin-shorthand-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/border-radius-property-value-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/modify-ua-rules-from-javascript-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/css/word-break-user-modify-allowed-values-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/StyleSheet/detached-parent-rule-without-wrapper-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/StyleSheet/detached-stylesheet-without-wrapper-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/StyleSheet/removed-media-rule-deleted-parent-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/StyleSheet/removed-stylesheet-rule-deleted-parent-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/getMatchedCSSRules-nested-rules-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/getMatchedCSSRules-parent-stylesheets-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-complex-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/get-matched-css-rules-with-dirty-dirstibution-crash-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/inspector-support/style-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-call-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-getMatchedCSSRules-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/security/cross-origin-getMatchedCSSRules2-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/linux/fast/inspector-support/matchedrules-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/inspector-support/matchedrules-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/inspector-support/matchedrules-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/inspector-support/matchedrules-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/Window.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
philipj_slow
tests
6 years ago (2014-12-03 09:46:30 UTC) #1
philipj_slow
one more
6 years ago (2014-12-03 10:28:53 UTC) #2
philipj_slow
PTAL
6 years ago (2014-12-03 11:05:29 UTC) #4
rune
lgtm when you have enough deprecation lgtms. Your current failures look like flakes, right?
6 years ago (2014-12-03 12:16:25 UTC) #5
philipj_slow
update platform expectations
6 years ago (2014-12-03 12:50:04 UTC) #6
philipj_slow
fast/inspector-support/matchedrules.html needed updated platform expectation. http://www.chromium.org/blink#launch-process says "No formal approval is needed to proceed with ...
6 years ago (2014-12-03 13:07:14 UTC) #7
rune
On 2014/12/03 at 13:07:14, philipj wrote: > fast/inspector-support/matchedrules.html needed updated platform expectation. > > http://www.chromium.org/blink#launch-process ...
6 years ago (2014-12-03 13:40:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764083002/60001
6 years ago (2014-12-03 21:14:33 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-03 21:17:10 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186451

Powered by Google App Engine
This is Rietveld 408576698