chrome/browser/extensions/api/socket/socket.cc - Issue 76403004: An implementation of chrome.socket.secure().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/socket.cc

Issue 76403004: An implementation of chrome.socket.secure(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a large-write test, some spelling/doc fixes, and a stronger check for canonicalized names. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/socket/socket.cc

diff --git a/chrome/browser/extensions/api/socket/socket.cc b/chrome/browser/extensions/api/socket/socket.cc

index 845b895b3b6f55f6de900a966770471bd29171fa..8d637efdb3e21787d46de90ffe622befa8d3de06 100644

--- a/chrome/browser/extensions/api/socket/socket.cc

+++ b/chrome/browser/extensions/api/socket/socket.cc

@@ -66,6 +66,7 @@ void Socket::WriteData() {

void Socket::OnWriteComplete(int result) {

io_buffer_write_ = NULL;

+ DCHECK(!write_queue_.empty());

WriteRequest& request = write_queue_.front();

if (result >= 0) {