An implementation of chrome.socket.secure().

chrome/browser/extensions/api/api_resource_manager.h

Index: chrome/browser/extensions/api/api_resource_manager.h
diff --git a/chrome/browser/extensions/api/api_resource_manager.h b/chrome/browser/extensions/api/api_resource_manager.h
index b459c2292b30c3fdf2ad3ea64dbd79b54b68081c..c9b3e179ac590fdc49c4b8781a1001c03969f537 100644
--- a/chrome/browser/extensions/api/api_resource_manager.h
+++ b/chrome/browser/extensions/api/api_resource_manager.h
@@ -133,6 +133,10 @@ class ApiResourceManager : public ProfileKeyedAPI,
     return data_->GetResourceIds(extension_id);
   }
 
+  bool Set(const std::string& extension_id, int api_resource_id, T* resource) {
+    return data_->Set(extension_id, api_resource_id, resource);
+  }
+
  protected:
   // content::NotificationObserver:
   virtual void Observe(int type,
@@ -214,6 +218,20 @@ class ApiResourceManager : public ProfileKeyedAPI,
       return GetOwnedResource(extension_id, api_resource_id);
     }
 
+    bool Set(const std::string& extension_id, int api_resource_id,
+             T* api_resource) {
+      DCHECK(content::BrowserThread::CurrentlyOn(thread_id_));
+      linked_ptr<T> old_resource_ptr = api_resource_map_[api_resource_id];

[Ryan Sleevi, 2013/11/25 17:30:13]

Is there a reason to take a copy of this linked_ptr?

Seems like you could just do

T* resource = api_resource_map_[api_resource_id].get();
if (resource && extension_id == resource->owner_extension_id()) {
  api_resource_map_[api_resource_id].reset(api_resource);
  return true;
}
return false;

Note that "else after return" is discouraged by the Chromium style guide. -
http://www.chromium.org/developers/coding-style#Code_Formatting

Finally, is either code correct? It seems it should be

if (resource && extension_id != resource->owner_extension_id())
    return false;
api_resource_map_[api_resource_id].reset(api_resource);
return true;

This covers the case where an API resource ID is not yet assigned (and assigns
it), where the API resource ID is assigned (and owned by the extension), and
when the API resource ID is assigned and NOT owned by the extension (and fails
appropriately)

+      T* old_resource = old_resource_ptr.get();
+      if (old_resource && extension_id == old_resource->owner_extension_id()) {
+        api_resource_map_[api_resource_id] = linked_ptr<T>(api_resource);
+        return true;
+      } else {
+        return false;
+      }
+    }
+
+
     base::hash_set<int>* GetResourceIds(const std::string& extension_id) {
       DCHECK(content::BrowserThread::CurrentlyOn(thread_id_));
       return GetOwnedResourceIds(extension_id);