An implementation of chrome.socket.secure().

chrome/browser/extensions/api/socket/tcp_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/tcp_socket.h"
 
 #include "chrome/browser/extensions/api/api_resource.h"
 #include "net/base/address_list.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
@@ skipping 288 matching lines @@
   DCHECK(!accept_callback_.is_null());
   if (result == net::OK && accept_socket_.get()) {
     accept_callback_.Run(
         result, static_cast<net::TCPClientSocket*>(accept_socket_.release()));
   } else {
     accept_callback_.Run(result, NULL);
   }
   accept_callback_.Reset();
 }
 
+void TCPSocket::Release() {
+  // Release() is only invoked when the underlying sockets are taken (via
+  // ClientStream()) by TLSSocket.  TLSSocket only supports CLIENT-mode
+  // sockets.
+
+  DCHECK(!server_socket_.release() && !accept_socket_.release())
+      << "TCPSocket::Release called in server mode.";
+
+  DCHECK(socket_mode_ == CLIENT);
+
+  // Release() doesn't disconnect the underlying sockets, but it does
+  // disconnect them from this TCPSocket.
+  is_connected_ = false;
+
+  connect_callback_.Reset();
+  read_callback_.Reset();
+  accept_callback_.Reset();
+
+  DCHECK(socket_.release() != NULL)

[Ryan Sleevi, 2014/03/12 23:35:27]

SECURITY BUG: This will not actually release socket_, because DCHECKs may be
compiled out. As such, it'll cause a double-free or a use-after-free.

Your original code was correct.

[lally, 2014/03/17 01:58:06]

Yikes.  Fixed.

+      << "TCPSocket::Release on null client socket.";
+}
+
+net::TCPClientSocket* TCPSocket::ClientStream() {
+  if (socket_mode_ != CLIENT || GetSocketType() != TYPE_TCP)
+    return NULL;
+  return socket_.get();
+}
+
+bool TCPSocket::HasPendingRead() const {
+  return !read_callback_.is_null();
+}
+
 ResumableTCPSocket::ResumableTCPSocket(const std::string& owner_extension_id)
     : TCPSocket(owner_extension_id),
       persistent_(false),
       buffer_size_(0),
       paused_(false) {
 }
 
 ResumableTCPSocket::ResumableTCPSocket(net::TCPClientSocket* tcp_client_socket,
                                        const std::string& owner_extension_id,
                                        bool is_connected)
@@ skipping 12 matching lines @@
     : TCPSocket(owner_extension_id),
       persistent_(false),
       paused_(false) {
 }
 
 bool ResumableTCPServerSocket::IsPersistent() const {
   return persistent();
 }
 
 }  // namespace extensions