An implementation of chrome.socket.secure().

chrome/browser/extensions/api/socket/socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_H_
 #define CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_H_
 
 #include <queue>
 #include <string>
 #include <utility>
@@ skipping 21 matching lines @@
 typedef base::Callback<
   void(int, scoped_refptr<net::IOBuffer> io_buffer, const std::string&, int)>
       RecvFromCompletionCallback;
 typedef base::Callback<
   void(int, net::TCPClientSocket*)> AcceptCompletionCallback;
 
 // A Socket wraps a low-level socket and includes housekeeping information that
 // we need to manage it in the context of an extension.
 class Socket : public ApiResource {
  public:
-  enum SocketType {
-    TYPE_TCP,
-    TYPE_UDP,
-  };
+  enum SocketType { TYPE_TCP, TYPE_UDP, TYPE_TLS };
 
   virtual ~Socket();
+
+  const std::string& hostname() const { return hostname_; }
+
+  void set_hostname(const std::string& hostname) { hostname_ = hostname; }
+
+  // |address| is a resolved IP address. Call set_hostname() to save the
+  // original DNS name of the host if this socket may later get upgraded to
+  // TLS (see TLSSocket::UpgradeSocketToTLS()).

[Ryan Sleevi, 2014/02/24 20:06:49]

Comment wise, this wording seems a bit on the wishy-washy side, in that it seems
more of a suggestion than clear guidance. Let's try this:

// Note: |address| contains the resolved IP address, not the hostname
// of the remote endpoint. In order to upgrade this socket to TLS,
// callers must also supply the hostname of the endpoint via
// |set_hostname()|.

[lally, 2014/02/27 17:05:59]

Done.

   virtual void Connect(const std::string& address,
                        int port,
                        const CompletionCallback& callback) = 0;
   virtual void Disconnect() = 0;
   virtual int Bind(const std::string& address, int port) = 0;
 
   // The |callback| will be called with the number of bytes read into the
   // buffer, or a negative number if an error occurred.
   virtual void Read(int count,
                     const ReadCompletionCallback& callback) = 0;
@@ skipping 37 matching lines @@
 
  protected:
   explicit Socket(const std::string& owner_extension_id_);
 
   void WriteData();
   virtual int WriteImpl(net::IOBuffer* io_buffer,
                         int io_buffer_size,
                         const net::CompletionCallback& callback) = 0;
   virtual void OnWriteComplete(int result);
 
-  const std::string address_;
+  // The DNS name of the host that this socket is connected to, used when
+  // verifying a TLS certificate.

[Ryan Sleevi, 2014/02/24 20:06:49]

// The hostname of the remote host that this socket is connected to.
// Note: This may contain an IP literal. In the case of IDNs, this
// will contain a series of A-LABELs, not U-LABELs.

Am I correct with that above comment? How do you handle IDN names? If you pass
them through, should this be a UTF-8 string? Or will you apply IDNA to
canonicalize from the JS?

And is it valid for callers to supply IP addresses, for IP address certs? If so,
what's the form of IPv6 - bracketed or unbracketed? (Presumably, the latter).

[lally, 2014/02/27 17:05:59]

I had to investigate to find out what the upper-layer behavior is.  This passes
through the UTF-8 string passed in from javascript.  It's passed directly from
the javascript API as just a hostname, so there won't be any parsing, and there
shouldn't be any brackets for IPv6 addresses.

Should I canonicalize?

[Ryan Sleevi, 2014/03/12 23:35:27]

At least the SSLSocket layer expects the canonicalized, valid form.

That is, all hostnames as A-Labels, IPv6 as bracketed. I'm not sure where you
want to do that, but that's at least needed.

+  std::string hostname_;
   bool is_connected_;
 
  private:
   friend class ApiResourceManager<Socket>;
   static const char* service_name() {
     return "SocketManager";
   }
 
   struct WriteRequest {
     WriteRequest(scoped_refptr<net::IOBuffer> io_buffer,
                  int byte_count,
                  const CompletionCallback& callback);
     ~WriteRequest();
     scoped_refptr<net::IOBuffer> io_buffer;
     int byte_count;
     CompletionCallback callback;
     int bytes_written;
   };
   std::queue<WriteRequest> write_queue_;
   scoped_refptr<net::IOBuffer> io_buffer_write_;
 };
 
 }  //  namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_SOCKET_SOCKET_H_