An implementation of chrome.socket.secure().

chrome/browser/extensions/api/socket/tcp_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/socket/tcp_socket.h"
 
 #include "chrome/browser/extensions/api/api_resource.h"
 #include "net/base/address_list.h"
 #include "net/base/ip_endpoint.h"
 #include "net/base/net_errors.h"
@@ skipping 288 matching lines @@
   DCHECK(!accept_callback_.is_null());
   if (result == net::OK && accept_socket_.get()) {
     accept_callback_.Run(
         result, static_cast<net::TCPClientSocket*>(accept_socket_.release()));
   } else {
     accept_callback_.Run(result, NULL);
   }
   accept_callback_.Reset();
 }
 
+
+void TCPSocket::Release() {
+  // Really, the 'server' bool/checks are to get around warn_unused_result on
+  // scoped_ptr.release().
+  bool server = false;
+  is_connected_ = false;  // Note: does _not_ disconnect any underlying sockets.
+  server = server_socket_.release() != NULL;
+  connect_callback_.Reset();
+  read_callback_.Reset();
+  accept_callback_.Reset();
+  server = accept_socket_.release() != NULL || server;

[Ryan Sleevi, 2013/11/25 17:30:13]

The whole |server| checks are *really* odd to me.

Seems like they should be either CHECKs, DCHECKs, or early failures *before* you
reset all the object state.

if (server_socket_ || accept_socket_) {
  return false;

[Lally Singh, 2013/12/05 17:07:12]

Fair enough.  Cleaned up.

+  net::TCPClientSocket* sock = socket_.release();
+  if (server) {
+    VLOG(1) << "TCPSocket::Release getting called in server mode.  Odd.";
+  } else if (sock == NULL && socket_mode_ == CLIENT) {
+    VLOG(1) << "TCPSocket::Release on null client socket.";
+  }
+}
+
+net::TCPClientSocket* TCPSocket::ClientStream() {
+  if (socket_mode_ != CLIENT || GetSocketType() != TYPE_TCP)
+    return NULL;
+  return socket_.get();
+}
+
 ResumableTCPSocket::ResumableTCPSocket(const std::string& owner_extension_id)
     : TCPSocket(owner_extension_id),
       persistent_(false),
       buffer_size_(0),
       paused_(false) {
 }
 
 ResumableTCPSocket::ResumableTCPSocket(net::TCPClientSocket* tcp_client_socket,
                                        const std::string& owner_extension_id,
                                        bool is_connected)
@@ skipping 12 matching lines @@
     : TCPSocket(owner_extension_id),
       persistent_(false),
       paused_(false) {
 }
 
 bool ResumableTCPServerSocket::IsPersistent() const {
   return persistent();
 }
 
 }  // namespace extensions