Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 764023007: Fix the sky build instructions (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix the sky build instructions Sky can't really build on its own. We were previously using the 'sky' build target for this but it didn't fully anticipate all of our dependencies. The most recent break was when James removed /mojo/shell from mojo. Instead of sky listing out each and every service which it depends on, we should just get used to building root like other mojo developers. Thankfully there is already a helpful tool for this called mojob.py. I've updated our readme to reflect this, and removed the mojo dependency on the sky build group. The purpose of the sky build group is to expose all of the sky build targets up to the root level BUILD.gn (which only depends on /sky), not to be an independently buildable target. R=jamesr@chromium.org, jamesr BUG= Committed: https://chromium.googlesource.com/external/mojo/+/1e66dcdee37189c760cec926e1e0923c82ef25cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M sky/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/HACKING.md View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years ago (2014-12-05 23:44:40 UTC) #1
jamesr
lgtm
6 years ago (2014-12-05 23:45:03 UTC) #2
eseidel
6 years ago (2014-12-05 23:46:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e66dcdee37189c760cec926e1e0923c82ef25cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698