Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 764003003: Reland parts of 'Use weak cells in map checks in polymorphic ICs' (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland parts of 'Use weak cells in map checks in polymorphic ICs' This relands macroassembler instructions and weak cell caching and does not include parts that caused "Linux ASan LSan" test failures. BUG=v8:3663 LOG=N

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -15 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +0 lines, -1 line 2 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/objects.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 8 chunks +57 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 5 chunks +114 lines, -0 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
6 years ago (2014-12-02 13:38:26 UTC) #2
mvstanton
LGTM, though I have a question about the ASM_UNIMPLEMENTED_BREAK statement. https://codereview.chromium.org/764003003/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (left): https://codereview.chromium.org/764003003/diff/1/src/arm64/lithium-codegen-arm64.cc#oldcode5022 ...
6 years ago (2014-12-02 13:45:20 UTC) #3
ulan
Thanks! https://codereview.chromium.org/764003003/diff/1/src/arm64/lithium-codegen-arm64.cc File src/arm64/lithium-codegen-arm64.cc (left): https://codereview.chromium.org/764003003/diff/1/src/arm64/lithium-codegen-arm64.cc#oldcode5022 src/arm64/lithium-codegen-arm64.cc:5022: ASM_UNIMPLEMENTED_BREAK("DoDeclareGlobals"); On 2014/12/02 13:45:20, mvstanton wrote: > What ...
6 years ago (2014-12-02 13:56:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/764003003/1
6 years ago (2014-12-02 13:56:24 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-02 14:25:24 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698