Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6526)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 763933002: Record container for hosted app launches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index af6d0388c4d92c7723e76aa700b1387518746be4..926b40557b36f95ef8417ebbabf7ce3413223079 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -143,9 +143,6 @@ WebContents* OpenEnabledApplication(const AppLaunchParams& params) {
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile);
prefs->SetActiveBit(extension->id(), true);
- UMA_HISTOGRAM_ENUMERATION(
- "Extensions.AppLaunchContainer", params.container, 100);
Ilya Sherman 2014/12/02 02:52:01 Please mark this histogram as <obsolete>
benwells 2014/12/02 04:31:30 Done.
-
if (CanLaunchViaEvent(extension)) {
// Remember what desktop the launch happened on so that when the app opens a
// window we can open them on the right desktop.
@@ -160,6 +157,9 @@ WebContents* OpenEnabledApplication(const AppLaunchParams& params) {
return NULL;
}
+ UMA_HISTOGRAM_ENUMERATION(
+ "Extensions.HostedAppLaunchContainer", params.container, 100);
Ilya Sherman 2014/12/02 02:52:02 Why are you setting the max for this histogram at
benwells 2014/12/02 04:31:30 No good reason. Updated to 4.
+
// Record v1 app launch. Platform app launch is recorded when dispatching
// the onLaunched event.
prefs->SetLastLaunchTime(extension->id(), base::Time::Now());
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698