Record container for hosted app launches.

chrome/browser/ui/extensions/application_launch.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/application_launch.h"
 
 #include <string>
 
 #include "apps/launcher.h"
 #include "base/metrics/histogram.h"
@@ skipping 126 matching lines @@
   const Extension* extension = GetExtension(params);
   if (!extension)
     return NULL;
   Profile* profile = params.profile;
 
   WebContents* tab = NULL;
   ExtensionPrefs* prefs = ExtensionPrefs::Get(profile);
   prefs->SetActiveBit(extension->id(), true);
 
   UMA_HISTOGRAM_ENUMERATION(
       "Extensions.AppLaunchContainer", params.container, 100);

[tapted, 2014/11/28 00:35:16]

Should we just delete this? params.container doesn't change, and isn't passed to
anything between here and the new one, so has no way of influencing anything.

Or: just move it? Consistency of the UMA data could be a reason why not, but
keeping the old metadata in histograms.xml feels like a debt. We could just
comment in the field description that before Mwhatever this included packaged
apps.

 
   if (CanLaunchViaEvent(extension)) {
     // Remember what desktop the launch happened on so that when the app opens a
     // window we can open them on the right desktop.
     PerAppSettingsServiceFactory::GetForBrowserContext(profile)->
         SetDesktopLastLaunchedFrom(extension->id(), params.desktop_type);
 
     apps::LaunchPlatformAppWithCommandLine(profile,
                                            extension,
                                            params.command_line,
                                            params.current_directory,
                                            params.source);
     return NULL;
   }
 
+  UMA_HISTOGRAM_ENUMERATION(
+      "Extensions.HostedAppLaunchContainer", params.container, 100);
+
   // Record v1 app launch. Platform app launch is recorded when dispatching
   // the onLaunched event.
   prefs->SetLastLaunchTime(extension->id(), base::Time::Now());
 
   GURL url = UrlForExtension(extension, params.override_url);
   switch (params.container) {
     case extensions::LAUNCH_CONTAINER_NONE: {
       NOTREACHED();
       break;
     }
@@ skipping 63 matching lines @@
 
   return tab;
 }
 
 bool CanLaunchViaEvent(const extensions::Extension* extension) {
   const extensions::FeatureProvider* feature_provider =
       extensions::FeatureProvider::GetAPIFeatures();
   extensions::Feature* feature = feature_provider->GetFeature("app.runtime");
   return feature->IsAvailableToExtension(extension).is_available();
 }