Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/renderer/print_web_view_helper_linux.cc

Issue 7639023: Revert 96567 - Reland 96406 - Print preview page selection should not require a rerendering of dr... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/print_web_view_helper_browsertest.cc ('k') | chrome/renderer/print_web_view_helper_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper_linux.cc
===================================================================
--- chrome/renderer/print_web_view_helper_linux.cc (revision 96579)
+++ chrome/renderer/print_web_view_helper_linux.cc (working copy)
@@ -29,29 +29,21 @@
PrintMsg_PrintPage_Params page_params;
page_params.params = print_preview_context_.print_params();
page_params.page_number = page_number;
- scoped_ptr<printing::Metafile> draft_metafile;
- printing::Metafile* initial_render_metafile =
- print_preview_context_.metafile();
- if (print_preview_context_.IsModifiable() && is_print_ready_metafile_sent_) {
- draft_metafile.reset(new printing::PreviewMetafile);
- initial_render_metafile = draft_metafile.get();
- }
base::TimeTicks begin_time = base::TimeTicks::Now();
PrintPageInternal(page_params,
print_preview_context_.GetPrintCanvasSize(),
- print_preview_context_.frame(), initial_render_metafile);
+ print_preview_context_.frame(),
+ print_preview_context_.metafile());
+
print_preview_context_.RenderedPreviewPage(
base::TimeTicks::Now() - begin_time);
- if (draft_metafile.get()) {
- draft_metafile->FinishDocument();
- } else if (print_preview_context_.IsModifiable() &&
- print_preview_context_.generate_draft_pages()){
- DCHECK(!draft_metafile.get());
- draft_metafile.reset(
+ scoped_ptr<printing::Metafile> page_metafile;
+ if (print_preview_context_.IsModifiable()) {
+ page_metafile.reset(
print_preview_context_.metafile()->GetMetafileForCurrentPage());
}
- PreviewPageRendered(page_number, draft_metafile.get());
+ PreviewPageRendered(page_number, page_metafile.get());
}
bool PrintWebViewHelper::PrintPages(const PrintMsg_PrintPages_Params& params,
@@ -215,8 +207,6 @@
SkRefPtr<skia::VectorCanvas> canvas = new skia::VectorCanvas(device);
canvas->unref(); // SkRefPtr and new both took a reference.
printing::MetafileSkiaWrapper::SetMetafileOnCanvas(canvas.get(), metafile);
- printing::MetafileSkiaWrapper::SetDraftMode(canvas.get(),
- is_print_ready_metafile_sent_);
frame->printPage(params.page_number, canvas.get());
// TODO(myhuang): We should render the header and the footer.
« no previous file with comments | « chrome/renderer/print_web_view_helper_browsertest.cc ('k') | chrome/renderer/print_web_view_helper_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698