Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3730)

Unified Diff: chrome/renderer/print_web_view_helper.h

Issue 7639023: Revert 96567 - Reland 96406 - Print preview page selection should not require a rerendering of dr... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/mock_render_thread.cc ('k') | chrome/renderer/print_web_view_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper.h
===================================================================
--- chrome/renderer/print_web_view_helper.h (revision 96579)
+++ chrome/renderer/print_web_view_helper.h (working copy)
@@ -6,6 +6,7 @@
#define CHROME_RENDERER_PRINT_WEB_VIEW_HELPER_H_
#pragma once
+#include <utility>
#include <vector>
#include "base/memory/scoped_ptr.h"
@@ -109,8 +110,6 @@
OnPrintForPrintPreview);
FRIEND_TEST_ALL_PREFIXES(PrintWebViewHelperPreviewTest,
OnPrintForPrintPreviewFail);
- FRIEND_TEST_ALL_PREFIXES(PrintWebViewHelperPreviewTest,
- OnPrintPreviewForSelectedPages);
#if defined(OS_WIN) || defined(OS_MACOSX)
FRIEND_TEST_ALL_PREFIXES(PrintWebViewHelperTest, PrintLayoutTest);
@@ -137,12 +136,14 @@
// Initialize the print preview document.
bool CreatePreviewDocument();
- // Continue generating the print preview.
- void OnContinuePreview();
+ // Continue generating the print preview. |requested_preview_page_index|
+ // specifies the browser requested preview page index. It is 1-based or
+ // |printing::INVALID_PAGE_INDEX| to continue with next page.
+ void OnContinuePreview(int requested_preview_page_index);
// Renders a print preview page. |page_number| is 0-based.
void RenderPreviewPage(int page_number);
- // Finalize the print ready preview document.
- bool FinalizePrintReadyDocument();
+ // Finalize the print preview document.
+ bool FinalizePreviewDocument();
// Abort the preview to put |print_preview_context_| into the 'UNINITIALIZED'
// state.
@@ -297,7 +298,6 @@
scoped_ptr<PrintMsg_PrintPages_Params> print_pages_params_;
bool is_preview_;
- bool is_print_ready_metafile_sent_;
// Used for scripted initiated printing blocking.
base::Time last_cancelled_script_print_;
@@ -331,12 +331,9 @@
// rendering took.
void RenderedPreviewPage(const base::TimeDelta& page_time);
- // Updates the print preview context when the required pages are rendered.
- void AllPagesRendered();
+ // Finalizes the print preview document.
+ void FinalizePreviewDocument();
- // Finalizes the print ready preview document.
- void FinalizePrintReadyDocument();
-
// Cleanup after print preview finishes.
void Finished();
@@ -351,17 +348,11 @@
bool IsReadyToRender() const;
bool IsBusy() const;
bool IsModifiable() const;
- bool IsLastPageOfPrintReadyMetafile() const;
- bool IsFinalPageRendered() const;
- // Setters
- void set_generate_draft_pages(bool generate_draft_pages);
-
// Getters
WebKit::WebFrame* frame() const;
WebKit::WebNode* node() const;
int total_page_count() const;
- bool generate_draft_pages();
printing::PreviewMetafile* metafile() const;
const PrintMsg_Print_Params& print_params() const;
const gfx::Size& GetPrintCanvasSize() const;
@@ -388,18 +379,17 @@
// Total page count in the renderer.
int total_page_count_;
- // List of page indices that need to be rendered.
- std::vector<int> render_page_list_;
+ // Number of pages to render.
+ int actual_page_count_;
- // Specifies the current list index.
- int render_page_list_index_;
+ // The current page to render.
+ int current_page_number_;
- // True, when draft pages needs to be generated.
- bool generate_draft_pages_;
+ // |rendered_pages_| tracks which pages need to be printed as well as
+ // the page slot it should be printed in. See GetPageSlotForPage.
+ typedef std::pair<bool, int> PreviewPageInfo;
+ std::vector<PreviewPageInfo> rendered_pages_;
- // Specifies the total number of pages in the print ready metafile.
- int print_ready_metafile_page_count_;
-
base::TimeDelta document_render_time_;
base::TimeTicks begin_time_;
« no previous file with comments | « chrome/renderer/mock_render_thread.cc ('k') | chrome/renderer/print_web_view_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698