Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Side by Side Diff: chrome/renderer/print_web_view_helper_win.cc

Issue 7639023: Revert 96567 - Reland 96406 - Print preview page selection should not require a rerendering of dr... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/renderer/print_web_view_helper_mac.mm ('k') | printing/print_job_constants.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/print_web_view_helper.h" 5 #include "chrome/renderer/print_web_view_helper.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/process_util.h" 10 #include "base/process_util.h"
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 } 119 }
120 120
121 Send(new PrintHostMsg_DidPrintPage(routing_id(), page_params)); 121 Send(new PrintHostMsg_DidPrintPage(routing_id(), page_params));
122 } 122 }
123 123
124 void PrintWebViewHelper::RenderPreviewPage(int page_number) { 124 void PrintWebViewHelper::RenderPreviewPage(int page_number) {
125 PrintMsg_Print_Params print_params = print_preview_context_.print_params(); 125 PrintMsg_Print_Params print_params = print_preview_context_.print_params();
126 // Calculate the dpi adjustment. 126 // Calculate the dpi adjustment.
127 float scale_factor = static_cast<float>(print_params.desired_dpi / 127 float scale_factor = static_cast<float>(print_params.desired_dpi /
128 print_params.dpi); 128 print_params.dpi);
129 scoped_ptr<Metafile> draft_metafile;
130 printing::Metafile* initial_render_metafile =
131 print_preview_context_.metafile();
132
133 if (print_preview_context_.IsModifiable() && is_print_ready_metafile_sent_) {
134 draft_metafile.reset(new printing::PreviewMetafile);
135 initial_render_metafile = draft_metafile.get();
136 }
137 129
138 base::TimeTicks begin_time = base::TimeTicks::Now(); 130 base::TimeTicks begin_time = base::TimeTicks::Now();
139 printing::Metafile* render_page_result = 131 printing::Metafile* render_page_result =
140 RenderPage(print_params, &scale_factor, page_number, true, 132 RenderPage(print_params, &scale_factor, page_number, true,
141 print_preview_context_.frame(), initial_render_metafile); 133 print_preview_context_.frame(),
134 print_preview_context_.metafile());
135 // In the preview flow, RenderPage will never return a new metafile.
136 DCHECK_EQ(render_page_result, print_preview_context_.metafile());
142 137
143 // In the preview flow, RenderPage will never return a new metafile.
144 DCHECK_EQ(render_page_result, initial_render_metafile);
145 print_preview_context_.RenderedPreviewPage( 138 print_preview_context_.RenderedPreviewPage(
146 base::TimeTicks::Now() - begin_time); 139 base::TimeTicks::Now() - begin_time);
147 140
148 if (draft_metafile.get()) { 141 scoped_ptr<printing::Metafile> page_metafile;
149 draft_metafile->FinishDocument(); 142 if (print_preview_context_.IsModifiable()) {
150 } else if (print_preview_context_.IsModifiable() && 143 page_metafile.reset(
151 print_preview_context_.generate_draft_pages()){
152 DCHECK(!draft_metafile.get());
153 draft_metafile.reset(
154 print_preview_context_.metafile()->GetMetafileForCurrentPage()); 144 print_preview_context_.metafile()->GetMetafileForCurrentPage());
155 } 145 }
156 PreviewPageRendered(page_number, draft_metafile.get()); 146 PreviewPageRendered(page_number, page_metafile.get());
157 } 147 }
158 148
159 Metafile* PrintWebViewHelper::RenderPage( 149 Metafile* PrintWebViewHelper::RenderPage(
160 const PrintMsg_Print_Params& params, float* scale_factor, int page_number, 150 const PrintMsg_Print_Params& params, float* scale_factor, int page_number,
161 bool is_preview, WebFrame* frame, Metafile* metafile) { 151 bool is_preview, WebFrame* frame, Metafile* metafile) {
162 PageSizeMargins page_layout_in_points; 152 PageSizeMargins page_layout_in_points;
163 GetPageSizeAndMarginsInPoints(frame, page_number, params, 153 GetPageSizeAndMarginsInPoints(frame, page_number, params,
164 &page_layout_in_points); 154 &page_layout_in_points);
165 155
166 int width; 156 int width;
(...skipping 19 matching lines...) Expand all
186 static_cast<int>(page_layout_in_points.margin_top), 176 static_cast<int>(page_layout_in_points.margin_top),
187 static_cast<int>(page_layout_in_points.content_width), 177 static_cast<int>(page_layout_in_points.content_width),
188 static_cast<int>(page_layout_in_points.content_height)); 178 static_cast<int>(page_layout_in_points.content_height));
189 SkDevice* device = metafile->StartPageForVectorCanvas( 179 SkDevice* device = metafile->StartPageForVectorCanvas(
190 page_size, content_area, frame->getPrintPageShrink(page_number)); 180 page_size, content_area, frame->getPrintPageShrink(page_number));
191 DCHECK(device); 181 DCHECK(device);
192 // The printPage method may take a reference to the canvas we pass down, so it 182 // The printPage method may take a reference to the canvas we pass down, so it
193 // can't be a stack object. 183 // can't be a stack object.
194 SkRefPtr<skia::VectorCanvas> canvas = new skia::VectorCanvas(device); 184 SkRefPtr<skia::VectorCanvas> canvas = new skia::VectorCanvas(device);
195 canvas->unref(); // SkRefPtr and new both took a reference. 185 canvas->unref(); // SkRefPtr and new both took a reference.
196 if (is_preview) { 186 if (is_preview)
197 printing::MetafileSkiaWrapper::SetMetafileOnCanvas(canvas.get(), metafile); 187 printing::MetafileSkiaWrapper::SetMetafileOnCanvas(canvas.get(), metafile);
198 printing::MetafileSkiaWrapper::SetDraftMode(canvas.get(),
199 is_print_ready_metafile_sent_);
200 }
201 188
202 float webkit_scale_factor = frame->printPage(page_number, canvas.get()); 189 float webkit_scale_factor = frame->printPage(page_number, canvas.get());
203 if (*scale_factor <= 0 || webkit_scale_factor <= 0) { 190 if (*scale_factor <= 0 || webkit_scale_factor <= 0) {
204 NOTREACHED() << "Printing page " << page_number << " failed."; 191 NOTREACHED() << "Printing page " << page_number << " failed.";
205 } else { 192 } else {
206 // Update the dpi adjustment with the "page |scale_factor|" calculated in 193 // Update the dpi adjustment with the "page |scale_factor|" calculated in
207 // webkit. 194 // webkit.
208 *scale_factor /= webkit_scale_factor; 195 *scale_factor /= webkit_scale_factor;
209 } 196 }
210 197
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 shared_buf.Unmap(); 278 shared_buf.Unmap();
292 return false; 279 return false;
293 } 280 }
294 shared_buf.GiveToProcess(base::GetCurrentProcessHandle(), shared_mem_handle); 281 shared_buf.GiveToProcess(base::GetCurrentProcessHandle(), shared_mem_handle);
295 shared_buf.Unmap(); 282 shared_buf.Unmap();
296 283
297 Send(new PrintHostMsg_DuplicateSection(routing_id(), *shared_mem_handle, 284 Send(new PrintHostMsg_DuplicateSection(routing_id(), *shared_mem_handle,
298 shared_mem_handle)); 285 shared_mem_handle));
299 return true; 286 return true;
300 } 287 }
OLDNEW
« no previous file with comments | « chrome/renderer/print_web_view_helper_mac.mm ('k') | printing/print_job_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698