Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 7639015: ARM: Optimize stubs for incremental marking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Incorporated second review by Erik Corry. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3201 matching lines...) Expand 10 before | Expand all | Expand 10 after
3212 3212
3213 // Swap elements. 3213 // Swap elements.
3214 __ ldr(scratch1, MemOperand(index1, 0)); 3214 __ ldr(scratch1, MemOperand(index1, 0));
3215 __ ldr(scratch2, MemOperand(index2, 0)); 3215 __ ldr(scratch2, MemOperand(index2, 0));
3216 __ str(scratch1, MemOperand(index2, 0)); 3216 __ str(scratch1, MemOperand(index2, 0));
3217 __ str(scratch2, MemOperand(index1, 0)); 3217 __ str(scratch2, MemOperand(index1, 0));
3218 3218
3219 Label no_remembered_set; 3219 Label no_remembered_set;
3220 __ CheckPageFlag(elements, 3220 __ CheckPageFlag(elements,
3221 scratch1, 3221 scratch1,
3222 MemoryChunk::SCAN_ON_SCAVENGE, 3222 1 << MemoryChunk::SCAN_ON_SCAVENGE,
3223 ne, 3223 ne,
3224 &no_remembered_set); 3224 &no_remembered_set);
3225 // Possible optimization: do a check that both values are Smis 3225 // Possible optimization: do a check that both values are Smis
3226 // (or them and test against Smi mask.) 3226 // (or them and test against Smi mask.)
3227 3227
3228 // We are swapping two objects in an array and the incremental marker never 3228 // We are swapping two objects in an array and the incremental marker never
3229 // pauses in the middle of scanning a single object. Therefore the 3229 // pauses in the middle of scanning a single object. Therefore the
3230 // incremental marker is not disturbed, so we don't need to call the 3230 // incremental marker is not disturbed, so we don't need to call the
3231 // RecordWrite stub that notifies the incremental marker. 3231 // RecordWrite stub that notifies the incremental marker.
3232 __ RememberedSetHelper( 3232 __ RememberedSetHelper(
(...skipping 1083 matching lines...) Expand 10 before | Expand all | Expand 10 after
4316 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value. 4316 __ mov(r1, Operand(r1, ASR, 1)); // Un-smi-tag value.
4317 __ add(pc, r1, Operand(masm_->CodeObject())); 4317 __ add(pc, r1, Operand(masm_->CodeObject()));
4318 } 4318 }
4319 4319
4320 4320
4321 #undef __ 4321 #undef __
4322 4322
4323 } } // namespace v8::internal 4323 } } // namespace v8::internal
4324 4324
4325 #endif // V8_TARGET_ARCH_ARM 4325 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698