Add isNotEmpty to core_matchers.

pkg/matcher/lib/src/core_matchers.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library matcher.core_matchers;
 
 import 'description.dart';
 import 'interfaces.dart';
 import 'util.dart';
 
 /// Returns a matcher that matches empty strings, maps or iterables
 /// (including collections).
 const Matcher isEmpty = const _Empty();
 
 class _Empty extends Matcher {
   const _Empty();
   bool matches(item, Map matchState) {
     if (item is Map || item is Iterable) {
       return item.isEmpty;
     } else if (item is String) {

[Lasse Reichstein Nielsen, 2014/11/27 15:22:46]

Consider merging String into the previous "if"-condition here too.

[dskloet, 2014/11/27 15:27:53]

It could just be:

return (item is Map || item is Iterable || item is String) && item.isEmpty;

[blackhc, 2014/11/28 16:12:29]

Done.

       return item.length == 0;
     } else {
       return false;
     }
   }
   Description describe(Description description) => description.add('empty');
 }
 
+/// Returns a matcher that matches non-empty strings, maps or iterables
+// (including collections).

[Lasse Reichstein Nielsen, 2014/11/27 15:22:46]

Second line isn't part of dartdoc-comment.

Document that this is based on the `isNotEmpty` property of the item, so if
something implements inconsistent `isEmpty`, `isNotEmpty` and `length`, it's
clear what is being tested.

[blackhc, 2014/11/28 16:12:29]

Done.

+const Matcher isNotEmpty = const _NotEmpty();
+
+class _NotEmpty extends Matcher {
+  const _NotEmpty();
+  bool matches(item, Map matchState) {
+    if (item is Map || item is Iterable || item is String) {

[dskloet, 2014/11/27 15:27:53]

return (item is Map || item is Iterable || item is String) && item.isNotEmpty;

[blackhc, 2014/11/28 16:12:29]

Done.

+      return item.isNotEmpty;
+    } else {
+      return false;
+    }
+  }
+  Description describe(Description description) => description.add('non-empty');
+}
+
 /// A matcher that matches any null value.
 const Matcher isNull = const _IsNull();
 
 /// A matcher that matches any non-null value.
 const Matcher isNotNull = const _IsNotNull();
 
 class _IsNull extends Matcher {
   const _IsNull();
   bool matches(item, Map matchState) => item == null;
   Description describe(Description description) => description.add('null');
@@ skipping 600 matching lines @@
         addDescriptionOf(matchState['feature']);
     var innerDescription = new StringDescription();
     _matcher.describeMismatch(matchState['feature'], innerDescription,
         matchState['state'], verbose);
     if (innerDescription.length > 0) {
       mismatchDescription.add(' which ').add(innerDescription.toString());
     }
     return mismatchDescription;
   }
 }