chrome/browser/sync/profile_sync_service.cc - Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.cc

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_service_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_mock.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service.cc

diff --git a/chrome/browser/sync/profile_sync_service.cc b/chrome/browser/sync/profile_sync_service.cc

index 2643f51ae95bfad483bb02e2e49094336ee1bb84..755845550b5e1f811719bcf82ac3922697d5dd7d 100644

--- a/chrome/browser/sync/profile_sync_service.cc

+++ b/chrome/browser/sync/profile_sync_service.cc

@@ -2501,10 +2501,7 @@ SigninManagerBase* ProfileSyncService::signin() const {

void ProfileSyncService::UnsuppressAndStart() {

DCHECK(profile_);

sync_prefs_.SetStartSuppressed(false);

- if (signin_.get() && !signin_->GetOriginal()->IsAuthenticated()) {

- signin_->GetOriginal()->SetAuthenticatedUsername(

- profile_->GetPrefs()->GetString(prefs::kGoogleServicesUsername));

- }

+ DCHECK(!signin_.get() || signin_->GetOriginal()->IsAuthenticated());

startup_controller_.TryStart();

}