chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc - Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nullptr Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

index a7d593949a4a44eb2e9d3aa8189c3d7cad0603e8..992a817b30dc2901ddd2f57059c6017f7cfcf441 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc

@@ -6,10 +6,12 @@

#include "base/prefs/pref_service.h"

#include "base/prefs/testing_pref_store.h"

#include "chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h"

+#include "chrome/browser/signin/signin_manager_factory.h"

#include "chrome/browser/sync/profile_sync_service_factory.h"

#include "chrome/common/extensions/api/signed_in_devices.h"

#include "chrome/common/pref_names.h"

#include "chrome/test/base/testing_profile.h"

+#include "components/signin/core/browser/signin_manager.h"

#include "extensions/browser/event_router.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -25,7 +27,8 @@ KeyedService* CreateProfileSyncServiceMock(content::BrowserContext* profile) {

// Adds a listener and removes it.

TEST(SignedInDevicesManager, UpdateListener) {

scoped_ptr<TestingProfile> profile(new TestingProfile());

- profile->GetPrefs()->SetString(prefs::kGoogleServicesUsername, "foo");

+ SigninManagerFactory::GetForProfile(profile.get())->

+ SetAuthenticatedUsername("foo");

ProfileSyncServiceFactory::GetInstance()->SetTestingFactory(

profile.get(), CreateProfileSyncServiceMock);

SignedInDevicesManager manager(profile.get());