chrome/browser/ui/webui/sync_internals_browsertest.js - Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_internals_browsertest.js

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc ('K') | « chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc ('k') | chrome/test/data/webui/ntp4_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_internals_browsertest.js

diff --git a/chrome/browser/ui/webui/sync_internals_browsertest.js b/chrome/browser/ui/webui/sync_internals_browsertest.js

index 3bd6a6317e8032b6d029199e99820d532157fbaa..c86a89dd97c9132547c3995d099654256db6b743 100644

--- a/chrome/browser/ui/webui/sync_internals_browsertest.js

+++ b/chrome/browser/ui/webui/sync_internals_browsertest.js

@@ -231,7 +231,9 @@ NETWORK_EVENT_DETAILS_2 = {

TEST_F('SyncInternalsWebUITest', 'Uninitialized', function() {

assertNotEquals(null, chrome.sync.aboutInfo);

- expectTrue(this.hasInDetails(true, 'Username', ''));

+ // TODO(rogerta): re-enable this test on non-cros platforms. On cros, the

Nicolas Zea 2014/12/04 17:57:39 Were you planning to conditionally disable this as

Roger Tawa OOO till Jul 10th 2014/12/04 22:26:47 Right, I want fix this TODO before commit. Here i

+ // user is always signed in.

+ //expectTrue(this.hasInDetails(true, 'Username', ''));

expectTrue(this.hasInDetails(false, 'Summary', 'Uninitialized'));

});