chrome/browser/chromeos/policy/device_local_account_browsertest.cc - Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/device_local_account_browsertest.cc

Issue 763673002: Replace direct access to kGoogleServicesUsername with calls to SigninManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/file_manager/file_manager_browsertest.cc ('K') | « chrome/browser/chromeos/login/session/stub_login_session_manager_delegate.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc » ('j') | chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/device_local_account_browsertest.cc

diff --git a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc

index b10af17f32501fe20140f003e253532a676a561b..976c27dc33ec840ed6b0d1b4b6d72fb67bb5749c 100644

--- a/chrome/browser/chromeos/policy/device_local_account_browsertest.cc

+++ b/chrome/browser/chromeos/policy/device_local_account_browsertest.cc

@@ -68,6 +68,7 @@

#include "chrome/browser/prefs/session_startup_pref.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

+#include "chrome/browser/signin/signin_manager_factory.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_finder.h"

@@ -98,7 +99,7 @@

#include "components/policy/core/common/policy_namespace.h"

#include "components/policy/core/common/policy_service.h"

#include "components/policy/core/common/policy_switches.h"

-#include "components/signin/core/common/signin_pref_names.h"

+#include "components/signin/core/browser/signin_manager.h"

#include "components/user_manager/user.h"

#include "components/user_manager/user_manager.h"

#include "components/user_manager/user_type.h"

@@ -935,8 +936,8 @@ IN_PROC_BROWSER_TEST_F(DeviceLocalAccountTest, StartSession) {

// account.

Profile* profile = GetProfileForTest();

ASSERT_TRUE(profile);

- EXPECT_FALSE(profile->GetPrefs()->HasPrefPath(

- prefs::kGoogleServicesUsername));

+ EXPECT_FALSE(

+ SigninManagerFactory::GetForProfile(profile)->IsAuthenticated());

}

IN_PROC_BROWSER_TEST_F(DeviceLocalAccountTest, FullscreenDisallowed) {