Replace direct access to kGoogleServicesUsername with calls to SigninManager.

chrome/browser/ui/webui/sync_internals_browsertest.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Test fixture for sync internals WebUI testing.
  * @constructor
  * @extends {testing.Test}
  */
 function SyncInternalsWebUITest() {}
@@ skipping 213 matching lines @@
 
 NETWORK_EVENT_DETAILS_2 = {
   'details': 'Received error: SYNC_AUTH_ERROR',
   'proto': {},
   'time': 1395874542192.837,
   'type': 'GetUpdates Response',
 };
 
 TEST_F('SyncInternalsWebUITest', 'Uninitialized', function() {
   assertNotEquals(null, chrome.sync.aboutInfo);
-  expectTrue(this.hasInDetails(true, 'Username', ''));
+  // TODO(rogerta): re-enable this test on non-cros platforms.  On cros, the

[Nicolas Zea, 2014/12/04 17:57:39]

Were you planning to conditionally disable this as part of this patch? I think
you can do it using GEN calls (see for example browser_options_browsertest.js

[Roger Tawa OOO till Jul 10th, 2014/12/04 22:26:47]

Right, I want fix this TODO before commit.  Here is a fix based on our email
thread.

+  // user is always signed in.
+  //expectTrue(this.hasInDetails(true, 'Username', ''));
   expectTrue(this.hasInDetails(false, 'Summary', 'Uninitialized'));
 });
 
 TEST_F('SyncInternalsWebUITest', 'LoadPastedAboutInfo', function() {
   // Expose the text field.
   $('import-status').click();
 
   // Fill it with fake data.
   $('status-text').value = JSON.stringify(HARD_CODED_ABOUT_INFO);
 
@@ skipping 135 matching lines @@
 
   // Click the dump-to-text button.
   $('dump-to-text').click();
 
   // Verify our event is among the results.
   var eventDumpText = $('data-dump').textContent;
 
   expectGE(eventDumpText.indexOf('onConnectionStatusChange'), 0);
   expectGE(eventDumpText.indexOf('CONNECTION_OK'), 0);
 });