Issue 763593002: Revert of some cleanup around GrGpu/GrDrawTarget copySurface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 763593002: Revert of some cleanup around GrGpu/GrDrawTarget copySurface (Closed)

Created:
6 years ago by bsalomon

Modified:
6 years ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@isSameAs

Project:
skia

Visibility:
Public.

Revert of some cleanup around GrGpu/GrDrawTarget copySurface (patchset #3 id:40001 of https://codereview.chromium.org/749903003/) Reason for revert: likely causing es rendering errors. Original issue's description: > some cleanup around GrGpu/GrDrawTarget copySurface > > Committed: https://skia.googlesource.com/skia/+/e9aa5dc4d5906788eaf691d7c69f1494928f401d TBR=joshualitt@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8ee4e601f9aa4199e62b57260780207fd26e446a

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+213 lines, -236 lines)			Patch
M	src/gpu/GrDrawTarget.h	View	6 chunks	+31 lines, -57 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	3 chunks	+12 lines, -16 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	2 chunks	+13 lines, -14 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.h	View	3 chunks	+23 lines, -20 lines	0 comments	Download
M	src/gpu/GrInOrderDrawBuffer.cpp	View	1 chunk	+19 lines, -14 lines	0 comments	Download
M	src/gpu/GrTest.cpp	View	1 chunk	+79 lines, -71 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View	2 chunks	+11 lines, -10 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	2 chunks	+18 lines, -34 lines	0 comments	Download

Total messages: 3 (0 generated)

bsalomon

Created Revert of some cleanup around GrGpu/GrDrawTarget copySurface

6 years ago (2014-11-26 18:19:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/763593002/1

6 years ago (2014-11-26 18:20:26 UTC) #2

commit-bot: I haz the power

6 years ago (2014-11-26 18:20:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8ee4e601f9aa4199e62b57260780207fd26e446a