Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2583)

Unified Diff: chrome/browser/chromeos/login/screens/base_screen.h

Issue 763563002: Implemented event-dispatching for button clicks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/base_screen.h
diff --git a/chrome/browser/chromeos/login/screens/base_screen.h b/chrome/browser/chromeos/login/screens/base_screen.h
index a9483929f94aef4023aae0e53fc10235acd4e7c4..1f015bcc30dbf420124c388b42c3d5c0dc85a221 100644
--- a/chrome/browser/chromeos/login/screens/base_screen.h
+++ b/chrome/browser/chromeos/login/screens/base_screen.h
@@ -80,7 +80,7 @@ class BaseScreen {
// Called when button with |button_id| was pressed. Notification
// about this event comes from the JS counterpart.
- virtual void OnButtonPressed(const std::string& button_id);
+ virtual void OnButtonClicked(const std::string& button_id);
dzhioev (left Google) 2014/11/27 12:08:51 I propose to rename this method to something more
Denis Kuznetsov (DE-MUC) 2014/11/27 13:51:41 OnUserAction() seems better to me.
ygorshenin1 2014/11/27 14:11:13 Done.
// The method is called each time some key in screen context is updated by JS
// side. Should be implemented in subclasses.

Powered by Google App Engine
This is Rietveld 408576698