Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: gin/test/v8_test.h

Issue 76353002: Introduce a Gin class instead of using global functions to control gin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/test/v8_test.h
diff --git a/gin/test/v8_test.h b/gin/test/v8_test.h
index 2b46f2412a1dab536818ea58276a2112f7cf8ee1..e7f93a64b7a9ba9cd3b6ecd9145bde5481103a1e 100644
--- a/gin/test/v8_test.h
+++ b/gin/test/v8_test.h
@@ -5,12 +5,16 @@
#ifndef GIN_TEST_V8_TEST_H_
#define GIN_TEST_V8_TEST_H_
+#include "base/basictypes.h"
#include "base/compiler_specific.h"
+#include "base/memory/scoped_ptr.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "v8/include/v8.h"
namespace gin {
+class Gin;
+
// A base class for tests that use v8.
class V8Test : public testing::Test {
public:
@@ -21,8 +25,11 @@ class V8Test : public testing::Test {
virtual void TearDown() OVERRIDE;
protected:
- v8::Isolate* isolate_;
+ scoped_ptr<Gin> instance_;
v8::Persistent<v8::Context> context_;
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(V8Test);
};
} // namespace gin

Powered by Google App Engine
This is Rietveld 408576698