Introduce a Gin class instead of using global functions to control gin

gin/test/file_runner.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/test/file_runner.h"
 
 #include "base/file_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "gin/converter.h"
+#include "gin/gin.h"
 #include "gin/modules/module_registry.h"
 #include "gin/test/gtest.h"
 #include "gin/try_catch.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace gin {
 
 namespace {
 
 base::FilePath GetModuleBase() {
@@ skipping 18 matching lines @@
   EXPECT_FALSE(try_catch.HasCaught()) << try_catch.GetPrettyMessage();
 }
 
 void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate) {
   ASSERT_TRUE(base::PathExists(path)) << path.LossyDisplayName();
   std::string source;
   ASSERT_TRUE(ReadFileToString(path, &source));
 
   base::MessageLoop message_loop;
 
-  gin::Runner runner(delegate, v8::Isolate::GetCurrent());
+  scoped_ptr<gin::Gin> instance(new gin::Gin);
+  gin::Runner runner(delegate, instance->isolate());
   gin::Runner::Scope scope(&runner);
   runner.Run(source);
 
   message_loop.RunUntilIdle();
 
-  v8::Handle<v8::Value> result = runner.context()->Global()->Get(
-      StringToSymbol(runner.isolate(), "result"));
-  std::string result_string;
-  ASSERT_TRUE(ConvertFromV8(result, &result_string));
-  EXPECT_EQ("PASS", result_string);
+  {
+    v8::Isolate::Scope isolate_scope(instance->isolate());
+    v8::HandleScope handle_scope(instance->isolate());

[abarth-chromium, 2013/11/19 15:49:21]

We're still in the Runner's scope.  I'm not sure this part is needed.  Maybe we
should put { } earlier so that RunUntilIdle happens outside the runner's scope?

[jochen (gone - plz use gerrit), 2013/11/19 15:57:24]

Right, I added this before I fixed Runner::Scope to have an Isolate::Scope as
member

+    v8::Handle<v8::Value> result = runner.context()->Global()->Get(
+        StringToSymbol(runner.isolate(), "result"));
+    std::string result_string;
+    ASSERT_TRUE(ConvertFromV8(result, &result_string));
+    EXPECT_EQ("PASS", result_string);
+  }
 }
 
 }  // namespace gin