Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: gpu/command_buffer/client/gles2_implementation_impl_autogen.h

Issue 763383002: GPU: Flush in glBind* to avoid being executed after future glDelete* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address a review issue Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | gpu/command_buffer/client/share_group.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/gles2_implementation_impl_autogen.h
diff --git a/gpu/command_buffer/client/gles2_implementation_impl_autogen.h b/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
index a0d2b5d166f84137dbcc1d07281f908d71abfc53..f1314fd47e8ce1ea8ef934c7f077e09842673c29 100644
--- a/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
+++ b/gpu/command_buffer/client/gles2_implementation_impl_autogen.h
@@ -30,9 +30,7 @@ void GLES2Implementation::BindBuffer(GLenum target, GLuint buffer) {
SetGLError(GL_INVALID_OPERATION, "BindBuffer", "buffer reserved id");
return;
}
- if (BindBufferHelper(target, buffer)) {
- helper_->BindBuffer(target, buffer);
- }
+ BindBufferHelper(target, buffer);
CheckGLError();
}
@@ -46,9 +44,7 @@ void GLES2Implementation::BindFramebuffer(GLenum target, GLuint framebuffer) {
"framebuffer reserved id");
return;
}
- if (BindFramebufferHelper(target, framebuffer)) {
- helper_->BindFramebuffer(target, framebuffer);
- }
+ BindFramebufferHelper(target, framebuffer);
CheckGLError();
}
@@ -62,9 +58,7 @@ void GLES2Implementation::BindRenderbuffer(GLenum target, GLuint renderbuffer) {
"renderbuffer reserved id");
return;
}
- if (BindRenderbufferHelper(target, renderbuffer)) {
- helper_->BindRenderbuffer(target, renderbuffer);
- }
+ BindRenderbufferHelper(target, renderbuffer);
CheckGLError();
}
@@ -77,9 +71,7 @@ void GLES2Implementation::BindTexture(GLenum target, GLuint texture) {
SetGLError(GL_INVALID_OPERATION, "BindTexture", "texture reserved id");
return;
}
- if (BindTextureHelper(target, texture)) {
- helper_->BindTexture(target, texture);
- }
+ BindTextureHelper(target, texture);
CheckGLError();
}
@@ -1593,9 +1585,7 @@ void GLES2Implementation::UseProgram(GLuint program) {
SetGLError(GL_INVALID_OPERATION, "UseProgram", "program reserved id");
return;
}
- if (UseProgramHelper(program)) {
- helper_->UseProgram(program);
- }
+ UseProgramHelper(program);
CheckGLError();
}
@@ -1959,9 +1949,7 @@ void GLES2Implementation::BindVertexArrayOES(GLuint array) {
SetGLError(GL_INVALID_OPERATION, "BindVertexArrayOES", "array reserved id");
return;
}
- if (BindVertexArrayOESHelper(array)) {
- helper_->BindVertexArrayOES(array);
- }
+ BindVertexArrayOESHelper(array);
CheckGLError();
}
@@ -2109,9 +2097,7 @@ void GLES2Implementation::BindValuebufferCHROMIUM(GLenum target,
"valuebuffer reserved id");
return;
}
- if (BindValuebufferCHROMIUMHelper(target, valuebuffer)) {
- helper_->BindValuebufferCHROMIUM(target, valuebuffer);
- }
+ BindValuebufferCHROMIUMHelper(target, valuebuffer);
CheckGLError();
}
« no previous file with comments | « gpu/command_buffer/client/gles2_implementation.cc ('k') | gpu/command_buffer/client/share_group.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698