scripts/slave/recipe_modules/isolate/api.py - Issue 763363002: Deterministic build: Add a whitelist to the compare_build_artifact script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/isolate/api.py

Issue 763363002: Deterministic build: Add a whitelist to the compare_build_artifact script (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/isolate/api.py

diff --git a/scripts/slave/recipe_modules/isolate/api.py b/scripts/slave/recipe_modules/isolate/api.py

index 421ee0996cc01f64614c17058a4c659be46cda39..048c177817e4dbac99f2e9707a74aeb2d88efb28 100644

--- a/scripts/slave/recipe_modules/isolate/api.py

+++ b/scripts/slave/recipe_modules/isolate/api.py

@@ -274,7 +274,8 @@ class IsolateApi(recipe_api.RecipeApi):

"""Compare the artifacts from 2 builds."""

args = [

'--first-build-dir', first_dir,

- '--second-build-dir', second_dir

+ '--second-build-dir', second_dir,

+ '--target-platform', self.m.chromium.c.TARGET_PLATFORM

]

self.m.python('compare_build_artifacts',

self.resource('compare_build_artifacts.py'),

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/isolate/resources/compare_build_artifacts.py » ('j') | no next file with comments »