Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 763353002: Revert of Introduce a kill-switch for shipping features. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Revert of Introduce a kill-switch for shipping features. (patchset #2 id:20001 of https://codereview.chromium.org/763273002/) Reason for revert: Reverted for breaking nosnap: http://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20nosnap/builds/1003/steps/Check/logs/Threading3 Original issue's description: > Introduce a kill-switch for shipping features. > > R=rossberg@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/d6285620868b15c84eb9affa59f6b4e869f074b8 TBR=rossberg@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 5 chunks +14 lines, -3 lines 0 comments Download
M src/flag-definitions.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
Created Revert of Introduce a kill-switch for shipping features.
6 years ago (2014-11-28 18:27:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/763353002/1
6 years ago (2014-11-28 18:27:36 UTC) #2
commit-bot: I haz the power
6 years ago (2014-11-28 18:27:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698